ultimate_alarm_clock icon indicating copy to clipboard operation
ultimate_alarm_clock copied to clipboard

Feature: [Discuss] the need for testing PR

Open AdarshRawat1 opened this issue 1 year ago • 2 comments

Current Problems

  • Inconsistent code formatting, causing problem in detecting changes and testing PRs ( Shows a lot of unnecessary changes in PR and may also introduce unwanted merge conflicts in future) Reference of such a event ( PR had to be reverted due to bugs) - Original PR - https://github.com/CCExtractor/ultimate_alarm_clock/pull/257 Revert - https://github.com/CCExtractor/ultimate_alarm_clock/pull/268

The problem is relevant for Beacon project as well [ https://github.com/CCExtractor/beacon ]

Solution

  • Adopt the official Dart formatting rules and use the dartfmt tool to automatically format Dart code on commit/push.
  • Use of linting tools
  • we can also use flutter drive for automating end-to-end UI testing and automated testing for unit tests and components as well

impact

  • dartfmt ensures consistent code style across the codebase for cleaner diffs.
  • Testing ensures that bugs are detected before going into production

Notes

  • Even if the testing might seem unnecessary at the moment for this application, but I strongly suggest using a linting or a standard formatting to ensure that changes made in PR are easier for maintainers to track and code base remains consistent.
  • This issue will be divided it into subtasks.
  • I would like to work on this.

AdarshRawat1 avatar Jan 04 '24 06:01 AdarshRawat1

I'll assign this to you, testing has definitely gotten more important for the application now. Let me know if you get stuck anywhere, happy to help :)

MarkisDev avatar Jan 07 '24 11:01 MarkisDev

The project is definitely growing, and we need a proper method of tracking changes. I would suggest https://docs.github.com/en/issues/planning-and-tracking-with-projects/learning-about-projects/about-projects, a Trello board, or some other project management solution.

Detective-Khalifah avatar Mar 07 '24 13:03 Detective-Khalifah