taskwarrior-flutter icon indicating copy to clipboard operation
taskwarrior-flutter copied to clipboard

fix: Avoid multiple theme checks

Open SGI-CAPP-AT2 opened this issue 11 months ago • 2 comments

Describe your improvement idea or feature request

Currently Across application there are multiple theme checks being done for every widget build. Like shown below: https://github.com/CCExtractor/taskwarrior-flutter/blob/d1d4ca29d488a804da7211b42cdf85514dcfa380/lib/app/modules/home/views/nav_drawer.dart#L24-L33

How would you like to see it implemented?

  1. Currently Global ThemeData are empty in utils/themes so populate them with existing values being used
  2. Refactor the code where checks are made if it's not causing any issue
  3. Change the theme with Get.changeTheme

Put here any screenshots or videos (optional)

No response

How can we contact you (optional)

@SGI-CAPP-AT2

Would you like to work on this issue?

Yes

By submitting this issue, I have confirmed that:

  • [X] I have starred the repo ⭐ and watched 👀 it on GitHub and followed the contribution guidelines.

SGI-CAPP-AT2 avatar Dec 15 '24 14:12 SGI-CAPP-AT2

@BrawlerXull please review this issue and assign me if it's appropriate to make changes

SGI-CAPP-AT2 avatar Dec 15 '24 14:12 SGI-CAPP-AT2

Hey the issues are open to be solved by everyone it will be merged on first come first serve basis First good pr will be merged

BrawlerXull avatar Dec 15 '24 15:12 BrawlerXull