rutorrent-flutter icon indicating copy to clipboard operation
rutorrent-flutter copied to clipboard

Issues found when analyzed the project's dart code

Open manoj1749 opened this issue 2 years ago • 7 comments

  • 10 issues found when we analyze the project's dart code using flutter analyze
  • Basically flutter analyze, Analyzes the project's Dart code.

Issues Found

info • 'toggleableActiveColor' is deprecated and shouldn't be used. No longer used by the framework,
          please remove any reference to it. For more information, consult the migration guide at
          https://flutter.dev/docs/release/breaking-changes/toggleable-active-color#migration-guide.
          This feature was deprecated after v3.4.0-19.0.pre • lib/theme/app_theme.dart:13:5 •
          deprecated_member_use
   info • 'toggleableActiveColor' is deprecated and shouldn't be used. No longer used by the framework,
          please remove any reference to it. For more information, consult the migration guide at
          https://flutter.dev/docs/release/breaking-changes/toggleable-active-color#migration-guide.
          This feature was deprecated after v3.4.0-19.0.pre • lib/theme/app_theme.dart:26:5 •
          deprecated_member_use
   info • 'primary' is deprecated and shouldn't be used. Use backgroundColor instead. This feature was
          deprecated after v3.1.0 • lib/ui/views/login/login_view.dart:159:31 • deprecated_member_use
   info • 'subtitle1' is deprecated and shouldn't be used. Use titleMedium instead. This feature was
          deprecated after v3.1.0-0.0.pre • lib/ui/widgets/dumb_widgets/document_type_card.dart:20:49 •
          deprecated_member_use
   info • 'primary' is deprecated and shouldn't be used. Use backgroundColor instead. This feature was
          deprecated after v3.1.0 • lib/ui/widgets/dumb_widgets/password_change_dialog_widget.dart:49:27
          • deprecated_member_use
   info • 'primary' is deprecated and shouldn't be used. Use backgroundColor instead. This feature was
          deprecated after v3.1.0 • lib/ui/widgets/dumb_widgets/torrent_label_dialog.dart:77:11 •
          deprecated_member_use
  error • The method 'FlatButton' isn't defined for the type '_FloatingBoxBottomSheet' •
         lib/ui/widgets/smart_widgets/bottom_sheets/bottom_sheet_setup.dart:88:19 • undefined_method
  error • The method 'FlatButton' isn't defined for the type 'ConfirmBottomSheetView' •
         lib/ui/widgets/smart_widgets/bottom_sheets/confirm_bottom_sheet/confirm_bottom_sheet_view.dart:
         53:15 • undefined_method
   info • 'primary' is deprecated and shouldn't be used. Use backgroundColor instead. This feature was
          deprecated after v3.1.0 •
          lib/ui/widgets/smart_widgets/url_bottom_sheet/url_bottomsheet_view.dart:77:19 •
          deprecated_member_use
   info • 'primary' is deprecated and shouldn't be used. Use backgroundColor instead. This feature was
          deprecated after v3.1.0 •
          lib/ui/widgets/smart_widgets/url_bottom_sheet/url_bottomsheet_view.dart:110:25 •
          deprecated_member_use

10 issues found. (ran in 2.2s)

manoj1749 avatar Mar 04 '23 18:03 manoj1749

  • Remove references to the deprecated member toggleableActiveColor and use the recommended replacement as per the migration guide.

  • Replace references to the deprecated member primary with backgroundColor.

  • Replace references to the deprecated member subtitle1 with titleMedium.

  • Import the FlatButton method in the relevant files.

vijaykarthiktk avatar Mar 05 '23 03:03 vijaykarthiktk

  • Remove references to the deprecated member toggleableActiveColor and use the recommended replacement as per the migration guide.

  • Replace references to the deprecated member primary with backgroundColor.

  • Replace references to the deprecated member subtitle1 with titleMedium.

  • Import the FlatButton method in the relevant files.

I had resolved those issues and also made a pr to the develop branch, btw thanks for your suggestions

manoj1749 avatar Mar 05 '23 03:03 manoj1749

I have already solved this issue in PR #188

virajbhartiya avatar Mar 22 '23 11:03 virajbhartiya

I have already solved this issue in PR #188

@virajbhartiya A pr is already made resolving this issue, and if you had gone through the conversations in this issue you could have seen the open pr's which have been referenced to this issue.

manoj1749 avatar Mar 22 '23 11:03 manoj1749

About time the issue is closed

Detective-Khalifah avatar Mar 25 '23 12:03 Detective-Khalifah

What Flutter SDK version did you guys use to build & run the project?

Detective-Khalifah avatar Apr 03 '23 02:04 Detective-Khalifah

Replace primary with background In flat button I think you used that somehere else and did not provide all the required things

dinpran avatar May 21 '23 14:05 dinpran