ccextractor icon indicating copy to clipboard operation
ccextractor copied to clipboard
verified publisher icon CCExtractor

[FIX] The first TODO in avc_functions.c and FIXME in avc_functions.c

Open steel-bucket opened this issue 7 months ago • 3 comments

In raising this pull request, I confirm the following (please check boxes):

  • [x] I have read and understood the contributors guide.
  • [x] I have checked that another pull request for this purpose does not exist.
  • [x] I have considered, and confirmed that this submission will be valuable to others.
  • [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • [x] I give this submission freely, and claim no ownership to its content.
  • [ ] I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • [ ] I have never used CCExtractor.
  • [ ] I have used CCExtractor just a couple of times.
  • [ ] I absolutely love CCExtractor, but have not contributed previously.
  • [x] I am an active contributor to CCExtractor.

This PR resolves one TODO and one FIXME in the avc_functions.c. The first TODO was - TODO: Do something if newsize == -1 (broken NAL) So, what my changes do is, print out a more verbose error message. The first FIXME was to check the set_fts function for CCX_NAL_TYPE_SEI which was only being checked in slice_header for NAL Type as CCX_NAL_TYPE_CODED_SLICE_IDR_PICTURE or CCX_NAL_TYPE_CODED_SLICE_NON_IDR_PICTURE_1.

There are more TODOs in the AVC Functions library, which need to be resolved before or during the porting to Rust. This PR will help in debugging and resolving the AVC Issues currently prevalent in CCExtractor.( #1626 , #1597 , #1592 )

steel-bucket avatar Apr 26 '25 21:04 steel-bucket

@prateekmedia I have AVC Functions in 11th week of my Plan, should we scrap this PR as the code will be redundant anyway?

steel-bucket avatar Jul 15 '25 21:07 steel-bucket

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 1c7e2a0...:
Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 7/7
DVD 3/3
DVR-MS 2/2
General 27/27
Hardsubx 1/1
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 86/86
Teletext 21/21
WTV 13/13
XDS 33/34

Your PR breaks these cases:

  • ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla e274a73653...

Congratulations: Merging this PR would fix the following tests:


It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

ccextractor-bot avatar Sep 29 '25 09:09 ccextractor-bot

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 1c7e2a0...:
Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 5/7
DVD 3/3
DVR-MS 2/2
General 27/27
Hardsubx 1/1
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 86/86
Teletext 7/21
WTV 13/13
XDS 34/34

Your PR breaks these cases:

Congratulations: Merging this PR would fix the following tests:

  • ccextractor --hardsubx 1a0302f7fd..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla e274a73653..., Last passed: Never

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

ccextractor-bot avatar Sep 29 '25 10:09 ccextractor-bot