ccextractor
ccextractor copied to clipboard
[WIP] [FIX] Initialize data structures for the rust CEA-708 decoder and correct Dtvcc
In raising this pull request, I confirm the following (please check boxes):
- [x] I have read and understood the contributors guide.
- [x] I have checked that another pull request for this purpose does not exist.
- [x] I have considered, and confirmed that this submission will be valuable to others.
- [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
- [x] I give this submission freely, and claim no ownership to its content.
- [x] I have mentioned this change in the changelog.
My familiarity with the project is as follows (check one):
- [ ] I have never used CCExtractor.
- [ ] I have used CCExtractor just a couple of times.
- [ ] I absolutely love CCExtractor, but have not contributed previously.
- [ ] I am an active contributor to CCExtractor.
Closes #1499
Work to be done in this PR:
- [x] Change Dtvcc::new() to create Dtvcc using ccx_decoder_dtvcc_settings as done here
- [x] Create a new extern C fn
ccxr_dtvcc_init()
in lib.rs and use this at all places wheredtvcc_init()
is being called. (Probably add a new struct field to lib_cc_decode likedtvcc_rust
and store Dtvcc there instead of using the dtvcc field) - [ ] Similar for
dtvcc_free()
- [ ] Change ccxr_process_cc_data to use Dtvcc from
dec_ctx
instead of creating a new one
Additionally to fix mp4 code flow:-
- [ ] Call the corresponding rust function here and pass Dtvcc as done in the above steps