ccextractor icon indicating copy to clipboard operation
ccextractor copied to clipboard

[FIX] Always write 2 bytes for UTF-16BE

Open prateekmedia opened this issue 1 year ago • 4 comments

In raising this pull request, I confirm the following (please check boxes):

  • [x] I have read and understood the contributors guide.
  • [x] I have checked that another pull request for this purpose does not exist.
  • [x] I have considered, and confirmed that this submission will be valuable to others.
  • [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • [x] I give this submission freely, and claim no ownership to its content.
  • [ ] I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • [ ] I have never used CCExtractor.
  • [ ] I have used CCExtractor just a couple of times.
  • [ ] I absolutely love CCExtractor, but have not contributed previously.
  • [x] I am an active contributor to CCExtractor.

Related to: #1451

prateekmedia avatar Sep 26 '23 18:09 prateekmedia

@canihavesomecoffee @cfsmp3 This PR is ready for review.

prateekmedia avatar Oct 23 '23 10:10 prateekmedia

@erankor Can you confirm if this works for you, or we have to do something else here?

prateekmedia avatar Dec 08 '23 11:12 prateekmedia

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit bce63b8...:

Report Name Tests Passed
Broken 12/13
CEA-708 14/14
DVB 4/7
DVD 3/3
DVR-MS 2/2
General 16/27
Hauppage 1/3
MP4 3/3
NoCC 10/10
Options 82/86
Teletext 21/21
WTV 13/13
XDS 27/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

  • ccextractor --out=sami --latin1 --autoprogram 5b4e0a6034..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 85271be4d2..., Last passed: Never
  • ccextractor --stdout --quiet --no-fontcolor 79a51f3500..., Last passed: Never
  • ccextractor --stdout --quiet --no-fontcolor 767b546f96..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 1974a299f0..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 132d7df7e9..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 99e5eaafdc..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 b22260d065..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla 7aad20907e..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla c41f73056a..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla 5d3a29f9f8..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla 15feae9133..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla 95dd33c6f1..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 01509e4d27..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 15feae9133..., Last passed: Never
  • ccextractor --autoprogram --out=srt --hauppauge --latin1 553d78e755..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --hauppauge --ucla --latin1 553d78e755..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --output-field 1 a65d39ccb3..., Last passed: Test 4760
  • ccextractor --out=spupng c83f765c66..., Last passed: Never
  • ccextractor --capfile /repository/Dictionary/MattS_dictionary.txt c83f765c66..., Last passed: Never
  • ccextractor --in=es dc7169d7c4..., Last passed: Test 4760
  • ccextractor --autoprogram --out=smptett --latin1 --ucla e274a73653..., Last passed: Test 4760
  • ccextractor --autoprogram --out=srt --latin1 --ucla b22260d065..., Last passed: Test 4760
  • ccextractor --autoprogram --out=ttxt --latin1 --xds --ucla c813e713a0..., Last passed: Test 4760
  • ccextractor --autoprogram --out=srt --latin1 --ucla c813e713a0..., Last passed: Test 4760
  • ccextractor --autoprogram --out=srt --latin1 --ucla c8dc039a88..., Last passed: Test 4760
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7d3f25c32c..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --ucla 7d3f25c32c..., Last passed: Never

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

ccextractor-bot avatar Jan 14 '24 18:01 ccextractor-bot

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit f08febf...:

Report Name Tests Passed
Broken 12/13
CEA-708 14/14
DVB 4/7
DVD 3/3
DVR-MS 2/2
General 16/27
Hauppage 1/3
MP4 2/3
NoCC 10/10
Options 81/86
Teletext 21/21
WTV 9/13
XDS 27/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

ccextractor-bot avatar May 25 '24 12:05 ccextractor-bot

I think this might not be correct solution, closing the PR.

prateekmedia avatar Aug 12 '24 14:08 prateekmedia