ccextractor icon indicating copy to clipboard operation
ccextractor copied to clipboard

[WIP] Port hardsubx classifier

Open shashwat1002 opened this issue 3 years ago • 2 comments

Starting port of the classifier module.

shashwat1002 avatar Jul 27 '22 18:07 shashwat1002

@PunitLodha awaiting feedback before I continue here because I have taken certain liberties.

The get_ocr_text_wordwise has a memory leak because it gives ownership of a Rust originating string to the C caller. According to documentation of CString it has to be deallocated using from_raw. That can only be done when the callers above have been ported. Therefore, I'm leaving that in for now. I might have to do it for the other functions in this module as well. Therefore, please take a look before I continue.

shashwat1002 avatar Aug 05 '22 06:08 shashwat1002

Logic seems fine. You can continue with the work. There are a few unwraps/panics and formatting issues, which can be reviewed later

PunitLodha avatar Aug 07 '22 05:08 PunitLodha

@PunitLodha

The classifier's porting is done. Please check

Note the currently I'm using the binding definition for AVPacket as opposed to ffmpeg_sys_next's I realised that it'll be better to make that change after this is merged.

shashwat1002 avatar Oct 03 '22 14:10 shashwat1002