ccextractor icon indicating copy to clipboard operation
ccextractor copied to clipboard

Create Linux AppImage

Open cfsmp3 opened this issue 3 years ago • 19 comments

The old build static script is useless. Let's replace it with AppImage as suggested ina comment below

cfsmp3 avatar Jun 13 '21 19:06 cfsmp3

It clones from master, so it will build the most recent... However the deps might not be up to date at all.

canihavesomecoffee avatar Jun 13 '21 19:06 canihavesomecoffee

It clones from master, so it will build the most recent... However the deps might not be up to date at all.

Ah yes. We just like to leave irrelevant comments around

# wget https://sourceforge.net/projects/ccextractor/files/ccextractor/0.82/ccextractor.src.0.82.zip;

cfsmp3 avatar Jun 13 '21 19:06 cfsmp3

@prateekmedia could you check this out? Probably you can fix it without a lot of pain.

Better - just make -static an arg to build :-)

cfsmp3 avatar Mar 22 '23 04:03 cfsmp3

Will look at it

prateekmedia avatar Mar 22 '23 05:03 prateekmedia

@cfsmp3 Could you explain what needs to be done in this? I looked at the file, ran it and it gave ccextractor-README.txt not found error.

prateekmedia avatar Mar 22 '23 11:03 prateekmedia

@cfsmp3 Could you explain what needs to be done in this? I looked at the file, ran it and it gave ccextractor-README.txt not found error.

This will give you some context

https://github.com/CCExtractor/ccextractor/issues/597

Note that I renamed the script from @traceypooh to build-static.sh without actually changing the context (not a great idea, I realize).

Still, the script is obsolete now but the idea is good.

Are we able to produce a static binary using Docker as container? (docker is great for this because you can have a reliable environment no matter the starting point in the host).

If you think that's not possible, or really a lot of work, I guess we should just remove build-static.sh for now because obviously it's not working and it's just going to confuse people.

cfsmp3 avatar Mar 22 '23 15:03 cfsmp3

I will try to do some testing from my side, let's see if I get it working.

prateekmedia avatar Mar 22 '23 15:03 prateekmedia

@cfsmp3 I think building static is not something we should do, instead why not build an AppImage (which is a universal format) and it will be able to run without being dependent on the system dependencies.

prateekmedia avatar Mar 23 '23 11:03 prateekmedia

@cfsmp3 I think building static is not something we should do, instead why not build an AppImage (which is a universal format) and it will be able to run without being dependent on the system dependencies.

That's a really good idea. It would also solve the eternal issues with tesseract training files, etc

cfsmp3 avatar Mar 23 '23 15:03 cfsmp3

@cfsmp3 Do you mean that tessdata should not be in the AppImage itself but installed separately?

prateekmedia avatar Mar 23 '23 15:03 prateekmedia

@cfsmp3 Do you mean that tessdata should not be in the AppImage itself but installed separately?

No, the opposite! If we could have a AppImage that included tessdata it would be fantastic.

And if the image came from the CI so we could always have a known good nightly it would solve most of our issues with fixes taking forever to reach users because we release a new version once a year or so.

cfsmp3 avatar Mar 23 '23 16:03 cfsmp3

yes

prateekmedia avatar Mar 23 '23 16:03 prateekmedia

Hey, Can i try making AppImage in replace of build-static.sh file Or this issue is just for the CCExtracter team?

IshanGrover2004 avatar Jan 23 '24 14:01 IshanGrover2004

You can work on it

cfsmp3 avatar Jan 23 '24 14:01 cfsmp3

You can work on it

Okk then I'll research and will open PR after working on it

Any information I should know before working on it?

IshanGrover2004 avatar Jan 23 '24 14:01 IshanGrover2004

@IshanGrover2004 You can began by reading appimage creation documentation and look at how other softwares are packaging the appimage.

prateekmedia avatar Jan 23 '24 16:01 prateekmedia

Yes, already started reading official AppImage docs

IshanGrover2004 avatar Jan 23 '24 16:01 IshanGrover2004

Hi, I have studied about AppImage from its official docs and have gained a good understanding of how it is created and red the build-static.sh file. The build-static.sh file contains so many not working commands and links. I am planning to make a .sh file which will run a docker alpine and setup the static library binary through which ccextracter binary file will be made which will be further placed it into AppDir and make final .AppImage file and then cleanup everything. I want to confirm if my approach is correct.

IshanGrover2004 avatar Jan 25 '24 13:01 IshanGrover2004

I have opened PR #1592 . Can anyone from CCExtractor team look on it, so that i resolve current issues in there.

IshanGrover2004 avatar Jan 30 '24 08:01 IshanGrover2004