ccextractor
ccextractor copied to clipboard
[BUG] X-TIMESTAMP-MAP doesn't show up with DVB subs
CCExtractor version: 0.88
- [X] I have read and understood the contributors guide.
- [X] I have checked that the bug-fix I am reporting can be replicated, or that the feature I am suggesting isn't already present.
- [X] I have checked that the issue I'm posting isn't already reported.
- [X] I have checked that the issue I'm porting isn't already solved and no duplicates exist in closed issues and in opened issues
- [X] I have checked the pull requests tab for existing solutions/implementations to my issue/suggestion.
- [X] I have used the latest available version of CCExtractor to verify this issue exists.
My familiarity with the project is as follows (check one, eg [X] - and delete unchecked ones):
- [X] I have used CCExtractor just a couple of times.
Necessary information
- Is this a regression (did it work before)? idk (probably not)
- What platform did you use? [X] Linux
arguments:
./ccextractor -datapid 0xc37 -out=webvtt files/test1_dvbsub.ts
Video link: http://akini.mbnet.fi/videos/test1_dvbsub.ts
Related to #1127 in goal though they have different "symptoms" and arise in different cases.
Info for some who wants to fix it:
This is the line that calls the function that adds the header (as well as the subtitles) when the input file isn't dvb:
https://github.com/CCExtractor/ccextractor/blob/3a1815163fed76683d7c92b0e7aaf32772e9e074/src/lib_ccx/ccx_encoders_common.c#L1160
This is the line that calls the function that doesn't do that:
https://github.com/CCExtractor/ccextractor/blob/3a1815163fed76683d7c92b0e7aaf32772e9e074/src/lib_ccx/ccx_encoders_common.c#L1220
So you basically want to second line to the the same thing as the first line. Feel free to ask more information if my instructions are unclear.
This is the line in write_cc_buffer_as_webvtt
that adds the header:
https://github.com/CCExtractor/ccextractor/blob/3a1815163fed76683d7c92b0e7aaf32772e9e074/src/lib_ccx/ccx_encoders_webvtt.c#L281
You want this line to be called in write_cc_bitmap_as_webvtt
Hello I am a newbie and I'm interested in solving this issue.Both the functions have the line write_webvtt_header(context) with the same context.What exactly is the issue?Can you elaborate about buffer and bitmap at bit. tess.log
test1_dvbsub.zip This TS file has more than one program. These are the program numbers found: 1501 1502 1503 fin.traineddata not found! Switching to English VBI/teletext stream ID 5100 (0x13ec) for SID 1503 (0x5df) Premature end of file - Transport Stream packet is incomplete (expected 188 bytes, got 92). 100% | 03:41 Number of NAL_type_7: 0 Number of VCL_HRD: 0 Number of NAL HRD: 0 Number of jump-in-frames: 0 Number of num_unexpected_sei_length: 0
Min PTS: 21:54:50:849 Max PTS: 21:58:32:650 Length: 00:03:41:801 Done, processing time = 35 seconds I am not getting the reason behind premature end.Thanks
Looking back at the code, I think this might be solved by #1137 (if it ever gets merged).
I believe this issue has been resolved due to the introduction of #1464. Anybody can easily attach the X-TIMESTAMP-MAP by utilizing the --timestamp-map option.