beacon icon indicating copy to clipboard operation
beacon copied to clipboard

Refresh indicator

Open Rushour0 opened this issue 1 year ago • 11 comments

Fixes # Added a custom pull to refresh mentioned in the issue #91 I have also made UI changes to the auth screen mentioned in the issue #158

Describe the changes you have made in this PR - Issue 91 Made a new TabControllerStorage since we cannot late initialise the tabcontroller, and thus cannot declare it out of the build method. Storing the tab index using this singleton implementation. Added a new package custom_refresh_indicator to implement the pull to refresh feature with a custom icon

Issue 158 Made changes to the UI to make it better looking and user friendly.

Screenshots of the changes (If any) - #91 Refresh Feature demo

https://user-images.githubusercontent.com/72869428/224340307-d131c550-cdbb-4c8c-9577-48ab56790817.mp4

#158 Improved Text Form Fields improved-text-form-field-0 improved-text-form-field-1

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Rushour0 avatar Mar 10 '23 14:03 Rushour0

@ItsAdityaKSingh you can check this PR for the earlier branch was not compatible with the newest main branch changes

Rushour0 avatar Mar 10 '23 14:03 Rushour0

Some formatting errors are failing in the test @Rushour0. Could you fix them?

ItsAdityaKSingh avatar Mar 11 '23 17:03 ItsAdityaKSingh

Some formatting errors are failing in the test @Rushour0. Could you fix them?

Check again @ItsAdityaKSingh

Rushour0 avatar Mar 11 '23 18:03 Rushour0

What changes have you made to the png? It doesn't seem to be changed.

It was causing issues in the release version app for some reason

Rushour0 avatar Mar 11 '23 19:03 Rushour0

https://stackoverflow.com/questions/51220827/appmergereleaseresources-exception-when-making-release-build

Faced this kind of an issue when I was building on the new flutter version. Probably because someone converted the image from jpg to png via plainly changing the extension name from .jpg to .png, instead of actual conversion of the image.

Rushour0 avatar Mar 11 '23 19:03 Rushour0

@ItsAdityaKSingh can we merge this branch?

Rushour0 avatar Mar 12 '23 17:03 Rushour0

What changes have you made to the png? It doesn't seem to be changed.

It was causing issues in the release version app for some reason

Could you show me a snapshot of the error you encountered?

ItsAdityaKSingh avatar Mar 13 '23 12:03 ItsAdityaKSingh

What changes have you made to the png? It doesn't seem to be changed.

It was causing issues in the release version app for some reason

Could you show me a snapshot of the error you encountered?

@ItsAdityaKSingh image

This is what I was seeing in the commit previous to that on running the command flutter build apk --release

Rushour0 avatar Mar 14 '23 12:03 Rushour0

Just a few UI changes, could you bring down the label text of the password below to the centre of the field? Looks a bit off. Also, the tabs in auth screen are not in the centre of the blue box around them; could you look into that too?

ItsAdityaKSingh avatar Mar 18 '23 11:03 ItsAdityaKSingh

Just a few UI changes, could you bring down the label text of the password below to the centre of the field? Looks a bit off. Also, the tabs in auth screen are not in the centre of the blue box around them; could you look into that too?

@ItsAdityaKSingh

Hey I checked the code, the issue is with the painter and will create issues on different sizes of mobile So is it okay to remove the animation but keeping the design and all same

Current look Previous look

Rushour0 avatar Mar 19 '23 09:03 Rushour0

@ItsAdityaKSingh check the last comment, what is your call on the changes?

Rushour0 avatar Mar 20 '23 08:03 Rushour0