beacon icon indicating copy to clipboard operation
beacon copied to clipboard

TextFormField separator removal

Open RohanSengupta326 opened this issue 3 years ago • 10 comments

Fixes #158

Describe the changes you have made in this PR -

  • Removed the separator between TextFormFields and inserted UnderlineInputBorder in both Existing and New Account Screen

Screenshots of the changes (If any) -

Screenshot 2022-10-13 at 4 13 20 PM Screenshot 2022-10-13 at 4 13 28 PM

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

RohanSengupta326 avatar Oct 13 '22 10:10 RohanSengupta326

Hey @RohanSengupta326! I guess it could be better to reduce and align the underline properly.

ItsAdityaKSingh avatar Oct 14 '22 20:10 ItsAdityaKSingh

how about this? @ItsAdityaKSingh

Screenshot 2022-10-15 at 1 07 07 PM

Screenshot 2022-10-15 at 1 07 07 PM

RohanSengupta326 avatar Oct 15 '22 07:10 RohanSengupta326

Better! Try to move that eye icon away from the underline. It should not look to be in the text field.

ItsAdityaKSingh avatar Oct 15 '22 11:10 ItsAdityaKSingh

@ItsAdityaKSingh

Screenshot 2022-10-16 at 2 08 00 PM

Screenshot 2022-10-16 at 2 08 51 PM

RohanSengupta326 avatar Oct 16 '22 08:10 RohanSengupta326

That's great! Could you also just push the eye icon up a little so that it comes above the underline horizontal space?

ItsAdityaKSingh avatar Oct 16 '22 09:10 ItsAdityaKSingh

Is this height of the eye icon okay or is more needed? @ItsAdityaKSingh

Screenshot 2022-10-16 at 2 43 11 PM Screenshot 2022-10-16 at 2 43 21 PM

RohanSengupta326 avatar Oct 16 '22 09:10 RohanSengupta326

LGTM! @nb9960, could you review?

ItsAdityaKSingh avatar Oct 16 '22 09:10 ItsAdityaKSingh

so should send the PR now or wait? @ItsAdityaKSingh

RohanSengupta326 avatar Oct 16 '22 11:10 RohanSengupta326

@nb9960

debug.keystore and pubspec.lock were changed automatically. I reverted the changes and committed including the UI changes. and also removed the separator widget as you asked. please check.

RohanSengupta326 avatar Oct 18 '22 08:10 RohanSengupta326

Hey @RohanSengupta326, could you please see PR #175 and discuss the need for separate cards for the fields or have the fields on the same card? You could look at the UI and suggest your ideas there too.

ItsAdityaKSingh avatar Dec 08 '22 16:12 ItsAdityaKSingh