LiquidBounce
LiquidBounce copied to clipboard
CCBlueX
Fixed modules that utilize CpsScheduler being flagged on anticheats on target switch.
So basically in dumb talk, if for example a module is automatically hitting a player with 6 CPS, then you re-enable the module and hit a player again, it will hit with almost double the CPS, causing anticheats to detect you for it.
Video to demonstrate what I mean: https://streamable.com/ghmavv
EDIT: Maybe it's just CpsScheduler in need of an improvement.
Yes, but you literally defeated the purpose of CpsScheduler. Minecraft counts the clicks of your mouse until the next tick and will do multiple clicks in one tick. It is more likely that we should improve the scheduler instead of removing it.
Yeah, I noticed that CPS is now less than the requested amount. Perhaps I should close this PR?
How much CPS did you set? It seems NCP is counting more than 15 clicks, which is way too much for legit users.
Yes, this is pretty much normal because it is milliseconds based and not ticks based and without the repeat it will not work correctly and miss a few clicks.
But when you set like 10cps with CPS Scheduler (with repeat) does it still flag? I don't remember having any issues with it when I was making it and I did test it on every major anticheat.
Yes, it does flag if I re-enable the module like I did in the video. What I notice is that at whatever CPS it is set to, it almost doubles it if you do that "trick"
Ok very weird. Should not happen, but I'll look into it when I'm back to nextgen.
Forgot to mention, there's also a problem when setting CPS values to 1-1, it hits once then never hits again.
Did a few tests with c45f037, and I can say that there are no issues anymore. Sudden CPS increase doesn't occur, 1-1 CPS making the function "freeze" is fixed, plus the code is simplified.