LiquidBounce
LiquidBounce copied to clipboard
CCBlueX
[BUG] toggling a module off shows a green checkmark
Describe the bug When you toggle off a module it shows a popup with a green checkmark instead of a red cross or similar to that.
To Reproduce Steps to reproduce the behavior:
- Toggle a module on and then off
I'm not sure if this is intentional behavior or not. I've definitely wondered the same myself but maybe @SenkJu can give more insight into this since he worked on the HUD.
Yeah I also wasn't sure. And if it's intended I'm suggesting to change it to a red cross because otherwise it's very hard to see what you did without reading.
I would say a red cross is more likely to be used for an error. Green indicates something has been successfully done.
I think that green tick should be for on, Red Cross should be for off, and yellow/orange explaination mark (!) should be for errors
something like this
This looks so wrong. Of course, it makes sense to show something "red" when you turn off but ... I don't know. It doesn't fit.
The problem is that notifications are intended to be as generic as possible. We want to use them for other things as well so adding specific icons for module toggle notifications would be a little strange.
No. There are other icons, but we probably won't use red-X icons for "Disabling module" which is basically a successful task (so it has to be Green)
It must be a green cross whether the module is disabled or enabled. The X icon should be for errors, and the ! icon should be for notification messages.
Examples:
X: Failed to load entities.
!: Speed module is disabled due to setback detection.
what about icons being for what type of notification and colours for the status of that thing in the category?
so the colours are for what happened, and the icon is for the category of that thing (like binds, settings, modules ect)
the icons dont need to be exactly like this, this is just showing off the idea
the icons dont need to be exactly like this, this is just showing off the idea
i think they look very good, i'd love if this got added
what, the icons? like i said, its just showing off the idea, they dont have to look like this
this is what i meant by the comment above btw
this looks cool, btw do you use gimp to edit cause i do too
Like I said, the icons don’t have to be exactly the same, they were just an example
No.
why
The icons don't really match its purpose.