LiquidBounce icon indicating copy to clipboard operation
LiquidBounce copied to clipboard

LEGACY: Added FakeItem RenderUtils

Open SuperSkidder opened this issue 9 months ago • 12 comments

More improvements needs to be done.

  1. AutoTool should switch back to former item before switching after digging
  2. Hotbar selection also needs to keep fake item slot.

SuperSkidder avatar May 01 '24 06:05 SuperSkidder

#1605 The PR is based on this issue

SuperSkidder avatar May 01 '24 06:05 SuperSkidder

this is the video: https://drive.google.com/file/d/1FumLdwbubp5ZzLQh5M57ltzrHw4jobOg/view?usp=sharing

SuperSkidder avatar May 01 '24 06:05 SuperSkidder

Thank you for actually adding this ♥️

EclipsesDev avatar May 01 '24 07:05 EclipsesDev

Is this ready for merge? @SuperSkidder

EclipsesDev avatar May 01 '24 07:05 EclipsesDev

Is this ready for merge? @SuperSkidder

no, I need to fix some bugs. I will @You when it is ready.

SuperSkidder avatar May 01 '24 07:05 SuperSkidder

Is this ready for merge? @SuperSkidder

no, I need to fix some bugs. I will @you when it is ready.

Ah ok 👍

EclipsesDev avatar May 01 '24 08:05 EclipsesDev

@EclipsesDev This feature was almost done, and I have tested it. You can merge it, but I recommend you to test it further to check if it would conflict with other modules.

SuperSkidder avatar May 02 '24 04:05 SuperSkidder

@EclipsesDev This feature was almost done, and I have tested it. You can merge it, but I recommend you to test it further to check if it would conflict with other modules.

I will check it out when I'm home

EclipsesDev avatar May 02 '24 04:05 EclipsesDev

@SuperSkidder K after checking, i've some suggestion to make.. is it done purposely or why don't u make it so in 3rd person it also stays as the original slot? and It would be nice too if u implement this on other modules that are using server slot.. like scaffold spoof autoblock and other modules too maybe. But overall its looking good 👍

EclipsesDev avatar May 02 '24 09:05 EclipsesDev

I'll implement 3rd perspective later. Other modules like Scaffold are good enough I think, it's not necessay to use this method to spoof slot.

SuperSkidder avatar May 03 '24 07:05 SuperSkidder

I'll implement 3rd perspective later. Other modules like Scaffold are good enough I think, it's not necessay to use this method to spoof slot.

Alright then ig I'll merge after u implement the 3rd person mode

EclipsesDev avatar May 03 '24 07:05 EclipsesDev

Merge now please

doesDeveloper avatar May 06 '24 06:05 doesDeveloper

Merge now please

Just wait for @SuperSkidder next commit, and it should be ready for merge

EclipsesDev avatar May 07 '24 11:05 EclipsesDev

So @SuperSkidder how's it?

EclipsesDev avatar May 09 '24 10:05 EclipsesDev

So @SuperSkidder how's it?

um I'm busy on study now. You can merge it now and I will make another PR to implement undone thing later.

SuperSkidder avatar May 10 '24 03:05 SuperSkidder

So @SuperSkidder how's it?

um I'm busy on study now. You can merge it now and I will make another PR to implement undone thing later.

I'll have time to do like next week or even longer

SuperSkidder avatar May 10 '24 03:05 SuperSkidder

Alright

EclipsesDev avatar May 10 '24 03:05 EclipsesDev