Benoît Cortier

> It might be related to this: [neovim/neovim#11202](https://github.com/neovim/neovim/issues/11202) I don't think it is because [it's supposed to be fixed](https://github.com/neovim/neovim/issues/11202#issuecomment-803365017), but I still have the issue with nightly `NVIM v0.5.0-dev+1314-g7b0edaac5` when...

I opened [a pull request](https://github.com/tokio-rs/tracing/pull/2497) to address the following point: > The ability to rotate log files based on a maximum size (rather than duration) [This pull request](https://github.com/tokio-rs/tracing/pull/2323) already addressed...

Hi @kirawi Any chance you could complete this PR?

CI is failing with: ``` error: failed to parse manifest at `/home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/opentelemetry-0.18.0/Cargo.toml` Caused by: feature `edition2021` is required this Cargo does not support nightly features, but if you switch to...

I rebased on master and addressed the comments

In my [last commit](https://github.com/tokio-rs/tracing/pull/2497/commits/097ccef40cea11c1efb78c570e607e9347fec823), I addressed an issue I had with this patch: [the overly specific date formatting](https://github.com/tokio-rs/tracing/pull/2497/commits/8a5ea2ef5755d678d6c6d518102050b729eb4350#diff-5042ae34347788466f8ab0443a19d2a64de1f4f8143bf7e42a43af4ba0a0d211R594-R595) was causing a new file to be created on start, always. So...

I addressed all comments made so far in https://github.com/tokio-rs/tracing/pull/2497/commits/9efcaecf2d4851ab3957c282ddd5d719dd835050 and https://github.com/tokio-rs/tracing/pull/2497/commits/3c86bd4c00bc4bdf662c6970c994ac4c24775f6d. I did not click on "resolve conversion" myself so the commenter can easily double check.

I cleaned a few last things. I want to add additional tests before merging, but otherwise I’m waiting for further reviews.

> Is there anything I can do to help get this pull request merged? To help me, you could add some additional tests (send a PR on my fork), but...

> I can help with tests. Any particular test cases that are missing, or should I just be creative? Thank you! There are two functions that I would like covered...