CanOpenSTM32 icon indicating copy to clipboard operation
CanOpenSTM32 copied to clipboard

Parameter mismatch in CO_CANinterrupt_TX

Open jafem opened this issue 2 years ago • 4 comments

There is a parameter argument mismatch in CO_CANinterrupt_TX, see CanOpenSTM32/stm32f0xx_can/Core/CANOpen_STM32F0xx/CO_driver_STM32F0xx.c CanOpenSTM32/stm32f3xx_can/Core/CANOpen_STM32F3xx/CO_driver_STM32F3xx.c

It is declared as void CO_CANinterrupt_TX(CO_CANmodule_t *CANmodule, uint32_t MailboxNumber)

but used as

void HAL_CAN_TxMailbox0CompleteCallback(CAN_HandleTypeDef *hcan){
	CO_CANinterrupt_TX(hcan,CAN_TX_MAILBOX0);
}
void HAL_CAN_TxMailbox1CompleteCallback(CAN_HandleTypeDef *hcan){
	CO_CANinterrupt_TX(hcan,CAN_TX_MAILBOX0);
}
void HAL_CAN_TxMailbox2CompleteCallback(CAN_HandleTypeDef *hcan){
	CO_CANinterrupt_TX(hcan,CAN_TX_MAILBOX0);
}

jafem avatar Sep 28 '22 10:09 jafem

@HamedJafarzadeh for you, no?

MaJerle avatar Sep 28 '22 13:09 MaJerle

@jafem You are right. Although that won't interfere with the actual stack, because we didn't use that argument in that function, but still your point is valid and needs to be removed. I'll fix that in the next revisions.

HamedJafarzadeh avatar Sep 28 '22 20:09 HamedJafarzadeh

@MaJerle Can you mark it as Pending fix or something similar so I don't forget it.

HamedJafarzadeh avatar Sep 28 '22 20:09 HamedJafarzadeh

Sure - you are now assigned and flag is added.

MaJerle avatar Sep 29 '22 06:09 MaJerle

We can close this.

HamedJafarzadeh avatar Nov 28 '22 21:11 HamedJafarzadeh