wycheproof icon indicating copy to clipboard operation
wycheproof copied to clipboard

Added seed based MLKEM test vectors

Open alex opened this issue 1 month ago • 4 comments

These are from #194 -- all I did was convert them to a JSON schema.

alex avatar Nov 27 '25 15:11 alex

(If it's useful, I can post the conversion script)

alex avatar Nov 27 '25 17:11 alex

Thanks! I haven't yet had the time to test and review this in detail. It looks like this adds more cases of multiple distinct test groups types in the same file, see #191 and https://github.com/C2SP/wycheproof/pull/192#issuecomment-3576250164, so the three testvectors_v1/mlkem_*_seed_test.json files may need to be split into three files each.

Also, have you considered if the mlkem_seed_test_schema.json can be merged into the mlkem_test_schema.json?

botovq avatar Nov 28 '25 16:11 botovq

🙃 went to make it consistent with the existing files, forgot that we wanted to split the existing ones apart.

alex avatar Nov 28 '25 18:11 alex

Ok, split apart now.

alex avatar Nov 29 '25 16:11 alex