fast-csv
fast-csv copied to clipboard
Add support for multiple delimiters
All Submissions:
- [x] Have you followed the guidelines in our Contributing document?
- [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
New Feature Submissions:
- [x] Have you added tests for the new feature
- [x] Does your submission pass tests?
- [x] Have you lint your code locally prior to submission?
- [x] Have you updated the docs?
- [ ] If you added new parsing or formatting options have you added them to the docs?
- [ ] If applicable have you added an example to the parsing or formatting docs?
Changes to Core Features:
- [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
- [ ] Have you written new tests for your core changes, as applicable?
- [ ] Have you successfully ran tests with your changes locally?
Addresses #1054
@willm looks like CI tests are failing. Mind reviewing them? The suite was having issues before so it probably wasn't caught when you opened the PR.
@juanri0s The issue #102 test was flaky due to not always completing in jest's default 5 second timeout, I increased the test timeout to 7 seconds. I hope this is acceptable, I'm pretty sure this was intermittently failing before my changes.
Hi @juanri0s is there any more feedback on this?