fast-csv icon indicating copy to clipboard operation
fast-csv copied to clipboard

Add support for multiple delimiters

Open willm opened this issue 1 year ago • 5 comments

All Submissions:

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. [x] Have you added tests for the new feature
  2. [x] Does your submission pass tests?
  3. [x] Have you lint your code locally prior to submission?
  4. [x] Have you updated the docs?
    • [ ] If you added new parsing or formatting options have you added them to the docs?
    • [ ] If applicable have you added an example to the parsing or formatting docs?

Changes to Core Features:

  • [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your core changes, as applicable?
  • [ ] Have you successfully ran tests with your changes locally?

willm avatar Nov 16 '24 23:11 willm

Addresses #1054

willm avatar Nov 16 '24 23:11 willm

@willm looks like CI tests are failing. Mind reviewing them? The suite was having issues before so it probably wasn't caught when you opened the PR.

juanri0s avatar Nov 21 '24 02:11 juanri0s

@juanri0s The issue #102 test was flaky due to not always completing in jest's default 5 second timeout, I increased the test timeout to 7 seconds. I hope this is acceptable, I'm pretty sure this was intermittently failing before my changes.

willm avatar Nov 21 '24 08:11 willm

Hi @juanri0s is there any more feedback on this?

willm avatar Dec 05 '24 13:12 willm