Chris Egerton
Chris Egerton
> Why do we need to do this? If the task has been cancelled and basically abandoned by the framework, it shouldn't really matter if the backoff takes up to...
Why construct the latches in `Worker`? Wouldn't it be cleaner to create them in the `RetryWithToleranceOperator` constructor and expose a method in that class to count down the latch, which...
Yeah, we can make assertions on when/how often/with which arguments `await` is called. If necessary, we can also manually advance the mock time by invoking `sleep` on it in our...
@tombentley FYI, I've finished rebasing this.
Thanks for fixing this @dstelljes! Two thoughts: First, can we add a test for this scenario, ideally one that fails without this change and succeeds with it? Second, you're correct...
### Hanging tests Phew, you got me worried there for a sec! I wrote the zombie fencing unit tests and we just merged them a week or two ago. I...
@dstelljes I just noticed that, with the changes in this PR, it's no longer possible to run individual test cases in this suite. For example, this command now fails: ```bash...
There's https://github.com/apache/kafka/pull/11792, but it's gone a bit stale (last activity was March 24th) and is marked as a draft. I've pinged the author to check on the status.
@dstelljes yep, that's what I'm seeing. Sorry for all the headaches here, hoping things will be easier once we switch over to Mockito. In the meantime, if you're up for...
By the way, @dstelljes, do you have an account on the project Jira? I'd like to assign the ticket it to you to indicate that it's being worked on but...