Chris Egerton

Results 151 comments of Chris Egerton

Thanks @vamossagar12. I haven't looked too closely at the code yet but have a couple high-level thoughts: 1. We should not introduce a backoff delay the first time a new...

@vamossagar12 there are failing unit tests, can you check those out and ping us after you've taken a look and fixed any issues?

@showuon The follow-up PR [here](https://github.com/vamossagar12/kafka/pull/1) is ready for review; this should be the last step necessary before we can merge this PR and fix this long-standing rebalancing bug.

@viktorsomogyi I'm not sure I understand the motivation for this change yet. The only time the offset reader should only be closed while the `MirrorSourceTask` is still running is when...

This kind of failure shouldn't persist across rebalances; we don't take task status (running vs. failed vs. unassigned) into account after rebalances when starting/restarting tasks. If the task is scheduled...

That's interesting--were you running a dedicated MM2 cluster, or were you deploying MM2 as a connector on a vanilla Kafka Connect cluster? And if the latter, were you able to...

I'm not opposed to improving error messages, but I'd like to ask again which version of Kafka Connect / MirrorMaker 2 you were running when you encountered this issue. We've...

Thanks @jolshan. I believe it's valid to perform preferred leader election for topics even if they're currently undergoing reassignment, for reasons [discussed in an earlier PR](https://github.com/apache/kafka/pull/9302#discussion_r491094781) for this ticket by...

@gitlw Are you still interested in pursuing this fix? I can provide a round of review if so.

@gitlw were you still planning on rebasing this PR?