C0rWin

Results 42 comments of C0rWin

guys, @maumueller, @jkatz can you please take a look on this PR?

@jkatz I have updated PR with changes you have mentioned.

@jkatz is there something else needed to be changed?

Are there any updates? IMO, getting results of PGVectorscale with ANN quite interesting to compare with baseline. Will appreciate review and suggestions for improvements.

> Hey sorry seeing this now. I can try to get it merged. Do I need to update/change anything? Fixed merge conflict.

> CI is failing on the Docker build: https://github.com/erikbern/ann-benchmarks/actions/runs/14031618414/job/39280343869?pr=539 Yeah, it's been quite a while since submission. I have had to update the cargo packages. It should work now. PS.....

@KoushikGavini I'm following up on this pull request for the Raft to BFT migration runbook. The DCO check is failing because the second commit in this PR isn't properly signed....

> Hi @C0rWin will take a look sorry must this got put in the bottom of my list No worries, will close it meanwhile, once you will have spare cycles...

``` --- FAIL: TestBlockPullerBadBlocks (10.17s) --- FAIL: TestBlockPullerBadBlocks/wrong_number (10.02s) deliver_test.go:1193: PullBlock did not complete within time 2024-08-27 19:43:17.184 UTC 133f INFO [grpc] Infof -> [transport] [client-transport 0xc00021e248] Closing: connection error:...

> Github is still using 22.04 for ubuntu-latest, and is still calling 24.04 'beta' for some reason - https://github.com/actions/runner-images?tab=readme-ov-file#available-images. How do you feel about using 22.04 for a more incremental...