joomla4-backend-template icon indicating copy to clipboard operation
joomla4-backend-template copied to clipboard

Published 20 hours ago • verified publisher icon C-Lodder

RTL improvements

Open C-Lodder opened this issue 5 years ago • 5 comments

Not tested on RTL yet but will definitely need fixes.

Will go with a separate CSS file and proper mixins rather than Atum's approach.

Need to look into what browsers already handle other than text alignment. That fact we don't support IE11 should make life a little easier.

C-Lodder avatar Dec 31 '19 12:12 C-Lodder

Happy to help on this.

Important note is that you must test using a real RTL language and not just set english to be rtl in the xml

brianteeman avatar Dec 31 '19 13:12 brianteeman

Cheers Brian. Glad you mentioned that, as I was going to do the later

C-Lodder avatar Jan 01 '20 11:01 C-Lodder

yeah the problem with the latter is that the language itself is encode as LTR and then you get some really weird results. Especially when it comes to punctuation at the end of lines. It's the number one issue I hear regularly from developers who have to work with rtl

brianteeman avatar Jan 01 '20 11:01 brianteeman

Started: https://github.com/C-Lodder/joomla4-backend-template/commit/e72d2adb88e26a755de244757be2c7e0f4cfb25d

  • Fixes sidebar menu
  • Fixes text alignment
  • Create some core mixins to cater for some CSS properties (wish browsers would just deal with this automatically)
  • Remove some unecessary IE code from reboot.scss

Rebuilds the 2 main CSS files with an -rtl suffix and dynamically setting $rtl: true;

C-Lodder avatar Jan 02 '20 16:01 C-Lodder

More RTL improvements done with logical properties: https://github.com/C-Lodder/joomla4-backend-template/commit/5d1480179c83d3cddb9e71612ce21939f193174f

Just waiting for Safari to catch up!!

C-Lodder avatar Apr 09 '20 08:04 C-Lodder