treediff-rs icon indicating copy to clipboard operation
treediff-rs copied to clipboard

Add Extra Test Case For Merger

Open zicklag opened this issue 3 years ago • 3 comments

Related to #6, it appears that even after the recent changes that this test still fails.

Also, it's worth noting that I decided to change gears on the way that I'm handling my original use-case, so I won't necessarily be using this anymore. So not super time critical on fixes or anything. :wink:

Also, I just submitted a PR for the test so it would be easy to try out, but you don't have to merge it or anything.

zicklag avatar Feb 25 '21 17:02 zicklag

Thanks a lot! I will definitely give the fix a shot, how hard can it be 😅.

Edit: I took a look and believe this is an issue with the 'value::set` implementation as it fails to set the value like its supposed to. It appears to be a bit too hardcoded to objects in the top-level, and I hope that there is a simple fix.

Byron avatar Feb 28 '21 07:02 Byron

Is this library still maintained ?

mitermayer avatar Mar 23 '23 08:03 mitermayer

Yes, it is. But for fixes I'd hope for contributions.

Byron avatar Mar 24 '23 08:03 Byron