DrawView icon indicating copy to clipboard operation
DrawView copied to clipboard

Eraser mode clears background

Open thanhpd56 opened this issue 6 years ago • 12 comments

Hi, Thanks for your great library. It's awsome. However i have an isssue that is when i change to eraser mode, it also clears background image. How can i prevent this? Thanks.

thanhpd56 avatar Jun 14 '18 14:06 thanhpd56

Hi @thanhpd56 !!!

God point! I can add a configuration to exclude background from eraser, wait for the update please

ByoxCode avatar Jul 09 '18 05:07 ByoxCode

Hi @ByoxCode , Thanks for your response. Is there any plan for the next release?

thanhpd56 avatar Jul 12 '18 23:07 thanhpd56

Sure, I'm working in a major update. Please wait for the next release. I'm planning changes for camera option, add more shapes, and in the snapshot branch I already added a improvement to load a background from remote image (url)

ByoxCode avatar Jul 13 '18 00:07 ByoxCode

Amazing! Thanks.

On Fri, Jul 13, 2018, 07:43 Oscar Gilberto Medina Cruz < [email protected]> wrote:

Sure, I'm working in a major update. Please wait for the next release. I'm planning changes for camera option, add more shapes, and in the snapshot branch I already added a improvement to load a background from remote image (url)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ByoxCode/DrawView/issues/25#issuecomment-404692120, or mute the thread https://github.com/notifications/unsubscribe-auth/ADnn0kQ8z0i0pFVR3g1OgFIdB8_sD2rNks5uF-0igaJpZM4UoDvF .

thanhpd56 avatar Jul 13 '18 01:07 thanhpd56

Hey @thanhpd56!! I released a snapshot version for new changes, you can see how to implement it in README.md

ByoxCode avatar Aug 01 '18 04:08 ByoxCode

Woah, great work! I will try it, and tell you the result soon.

thanhpd56 avatar Aug 01 '18 14:08 thanhpd56

Hi @ByoxCode, I try to import new snapshot version but it failed. maven { url "https://raw.githubusercontent.com/ByoxCode/DrawView/snapshot/aar/snapshots/" } `` implementation 'com.byox.drawview:drawview:1.3.1-SNAPSHOT' Unable to resolve dependency for ':app@prodFullDebug/compileClasspath': Could not resolve com.byox.drawview:drawview:1.3.1-SNAPSHOT.

What should i do?

thanhpd56 avatar Aug 01 '18 14:08 thanhpd56

Oh, It should be 1.0.0-SNAPSHOT. By the way, you changed api alot. @@

thanhpd56 avatar Aug 01 '18 16:08 thanhpd56

@ByoxCode Now it's working well. However, when i save image the background image is gone, only draw path.

thanhpd56 avatar Aug 01 '18 17:08 thanhpd56

@thanhpd56 really? Well I check this again, thanks!

ByoxCode avatar Aug 02 '18 04:08 ByoxCode

@ByoxCode One more problem, that mentioned from this. It still happens in this version. You can produce this issue by open drawview, then press home so that application turns to background => Crash. The solution is creating new class extends original graphic Matric and also implements Serializable. Thanks, wait for new update.

thanhpd56 avatar Aug 02 '18 13:08 thanhpd56

This line

mDrawView.setBackgroundImage(bitmap,BackgroundType.BITMAP,BackgroundScale.FIT_START); Change to :

  Drawable drawable = new BitmapDrawable(getResources(), bitmap);
                        mDrawView.setBackground(drawable);

But problem is , when click save, background not save :( any help @ByoxCode @thanhpd56

ibrahimsu avatar Mar 31 '19 02:03 ibrahimsu