Andrey Bykiev
Andrey Bykiev
The current implementation looks not good, every time on compiling expression it cleans the cache. Also the life of such cache is not big and will be flushed on every...
> What do you think about tracking the number of compilations and clean the cache on some predefined interval? It could also be done via a scheduled Timer. We can...
> I do agree that pruning the cache on every new expression parsing step is probably excessive. Could we use `IDisposable` for the cleanup? We could eagerly remove an expression...
@david-brink-talogy, what do you think about became a maintainer? I see @sklose doesn't have enough time, but I want to make some more changes in NCalc and my last PR...
> I would love to be a maintainer, I created 5 PRs and no one responded me near a week at the original NCalc :( > > Also what about...
@gumbarros, I reviewed your changes in NCalc, would you like to create a PR with cache changes here? It should close https://github.com/sklose/NCalc2/issues/39
@Thaina, I believe it'll be better to use `EvaluateOptions.IterateParameters` like this: https://github.com/sklose/NCalc2/blob/f8e42df6dbdb713cfb401063059b5d7d9d32b622/test/NCalc.Tests/Fixtures.cs#L655-L664
I've [tried](https://github.com/sklose/NCalc2/pull/97) to reproduce the issue with no luck
> @Bykiev I got some occasional test run error on that test recently when running it first time, then it disappeared What is a target framework? I've tried to reproduce...
From the [docs](https://learn.microsoft.com/en-us/dotnet/api/system.collections.concurrent.concurrentdictionary-2.addorupdate?view=net-8.0#System_Collections_Concurrent_ConcurrentDictionary_2_AddOrUpdate__0_System_Func__0__1__System_Func__0__1__1__): > For modifications and write operations to the dictionary, [ConcurrentDictionary](https://learn.microsoft.com/en-us/dotnet/api/system.collections.concurrent.concurrentdictionary-2?view=netframework-4.5) uses fine-grained locking to ensure thread safety (read operations on the dictionary are performed in a lock-free...