Dan Norman

Results 87 comments of Dan Norman

I was able to change `float` to `Decimal` using `msgspec`. The key is you need to generate a `Struct` from `SCHEMA` messages. The code is not elegant but working. If...

Hi @s7clarke10 , That is great news. Thanks for sharing how you are using `msgspec` in singer-python. I will defiantly be looking it over to see how you leveraged `msgspec`.

@edgarrmondragon, I have a question on how I should deal with the SCHEMA found in `singer_sdk\testing\target_test_streams\optional_attributes.singer` . In the SCHEMA message there is the `required` field which has a list...

@edgarrmondragon > Strictly speaking there's probably a distinction to be made between missing and null fields, e.g. a string field could be missing but not nullable I used the [UNSET](https://jcristharif.com/msgspec/supported-types.html#unset)...

@edgarrmondragon Yesterday I finished updating the `decoder` in `io_base.py` to use the new `float_hook` argument that was added in msgspec 0.18.0. The `float_hook` addition drastically reduced the amount of code...

@edgarrmondragon, I was wondering since there is a `SingerReader` class in `singer_sdk.io_base.` What do you think of a `SingerWriter` class being added to that file and moving the msgspec `encoder`,...

> @BuzzCutNorman Yeah, I like the symmetry of that 👍 @edgarrmondragon I just finished adding the `SingerWriter` class to `io_base`. Please take a look when you get a chance.

>>> @BuzzCutNorman Yeah, I like the symmetry of that 👍 >> >>@edgarrmondragon I just finished adding the SingerWriter class to io_base. Please take a look when you get a chance....

@edgarrmondragon I believe this PR is passing all the tests now. I did have to setup `xfail` for a few legacy tests. They run fine alone but fail when run...

@edgarrmondragon Yay!! 🥳there are lightning bolts ⚡ in the [CodSpeed Performace Analysis](https://github.com/meltano/sdk/pull/1784/checks?check_run_id=19458784139) report for the new JSON encode decode tests.