Jay comments

Results 445 comments of

Jay

Set AR environment variable based on return from CC

Hi, can you resolve the conflicts?

Bot comment links 404

Sorry, I think it should reference to https://github.com/tikv/tikv/blob/master/CONTRIBUTING.md instead.

Help On Sample

Maybe take a look at https://github.com/BusyJay/mini-pd, you can start from https://github.com/BusyJay/mini-pd/blob/main/tests/integration/cluster.rs.

Do not pass -jN to make, use cargo jobserver instead

> The fix is to remove the -jN arg to make if the CARGO_MAKEFLAGS env var exists, and set MAKEFLAGS to CARGO_MAKEFLAGS instead. Make sense. Would you like to send...

Do not pass -jN to make, use cargo jobserver instead

Likely the same problem as https://github.com/tikv/jemallocator/issues/32.

Do not pass -jN to make, use cargo jobserver instead

> MAKEFLAGS=" -- OBJECTS=init.o SHLIB=polars.so -j --jobserver-fds=8,9 --jobserver-auth=8,9" "make" The problem may come from `--`, which requires argument for flags, and -j has no aurgument, so it will be parsed...

Do not pass -jN to make, use cargo jobserver instead

LGTM, in worse case, job sever is overridden by user provided flags, which seems OK.

change progress status to replicate when handling heartbeat response

Make sense. I see upstream has already fix this issue in https://github.com/etcd-io/raft/pull/52, how about just porting the patch instead?

duplicate symbol definition: _malloc_printf

Can you also attach the build log of tikv-jemallocator? It should be in target/debug/build/tikv-jemalloc-sys-{hash}/output.

duplicate symbol definition: _malloc_printf

Perhaps you can also try to build with zig 0.13.0 and tikv-jemalloc 0.5.0. I'm not familiar with Zig, it's possible a new release zig brings new symbols in libSystem.tbd.