Jay
How about only making this lint work on `if let/else`? In most cases, it's easy to understand the lock will exist during the loop or in `match` block. But it's...
0.13.0 is published, please try again and see if it's fixed.
I think that's because compiler can't figure out the correct type for `Err(e)`.
If the stats are always collected in C/C++ code, then there seems to be no benefits to make it an optional feature.
> If so, `GRPCIO_SYS_USE_PKG_CONFIG` needs to be removed because stats need to include files under `grpc/src`. You can depend on GRPCIO_SYS_USE_PKG_CONFIG to decide whether implement the feature. By the way,...
> Do you mean functions in stats become no-op when GRPCIO_SYS_USE_PKG_CONFIG=1 Maybe you should use a feature name `internals` to indicate the APIs are available only when they are compiled...
How about moving c changes, for example, exposing a header, to tikv/grpc instead? So that users can choose to patch grpc or just ignore unknown symbols.