python-sc2 icon indicating copy to clipboard operation
python-sc2 copied to clipboard

Change some units (Reaper grenade) to effects

Open BurnySc2 opened this issue 6 years ago • 2 comments
trafficstars

  • [x] Reaper grenade should be an effect and not a structure
  • [x] Parasitc bomb (after the unit has died, the effect still lives on as a unit) should be an effect
  • [x] Force field should be an effect not a unit

This can probably be achieved here https://github.com/BurnySc2/python-sc2/blob/9caa5151e04ea3107d29475949d230f52e44efac/sc2/bot_ai.py#L835 by removing them from units and adding them to self.state.effects

  • [ ] Fix ravager bile effect While we are at it, the ravager bile is removed from the API too early before the bile has landed on the destination. Units will no longer try to dodge this and will probably take damage. This might need to be stored for a couple frames, or should this be handled bot specifically?
  • [ ] Tactical Nuke probably has the same problem

BurnySc2 avatar Jun 08 '19 14:06 BurnySc2

Completed first three tasks in https://github.com/BurnySc2/python-sc2/commit/034b71af3828914d83dc10c45e9da97fa4517e0e

tweakimp avatar Jun 08 '19 20:06 tweakimp

Added Nuke to task list

tweakimp avatar Jun 09 '19 10:06 tweakimp