ripgrep icon indicating copy to clipboard operation
ripgrep copied to clipboard

moving .ts from typoscript to TypeScript

Open Mellbourn opened this issue 2 years ago • 3 comments

The TypeScript language is in the top ten of the most popular programming languages.

Typoscript is a custom language for the TYPO3 CMS, that is far less used.

I think that the .ts extension should belong to the typescript type in ripgrep, not typoscript.

Mellbourn avatar Sep 29 '21 21:09 Mellbourn

The ts file type already exists. That's for typescript.

File types don't own extensions. Multiple file types may have the same globs.

BurntSushi avatar Sep 29 '21 22:09 BurntSushi

Right you are. It was a bit confusing that I could start to type typ in the shell and the completion system suggested typoscript, which I initially thought was a typo :D

Mellbourn avatar Sep 29 '21 22:09 Mellbourn

So

    ("typescript", &["*.ts"]),
    ("typoscript", &["*.ts", "*.typoscript"]),

would be better, right?

matkoniecz avatar Nov 22 '21 14:11 matkoniecz

This is wrong. Firstly, if ts and typescript are referring to the same thing, then they should have the same globs. This PR does not have that. Secondly, this PR removes a glob from typoscript without justifying it.

BurntSushi avatar Jul 08 '23 17:07 BurntSushi