nflgame icon indicating copy to clipboard operation
nflgame copied to clipboard

2018 Postseason and Super Bowl Issues Documented and explained

Open arnm opened this issue 7 years ago • 7 comments

https://www.youtube.com/watch?v=6Y0cBnlee2Y

arnm avatar Feb 07 '19 17:02 arnm

This project has been unmaintained for almost a year. There is an active fork (not super active at the moment but that might change) where for instance I have contributed some fixes.

https://github.com/derek-adair/nflgame

I very briefly checked the video but it seemed like a fun thing :) Anyhow, I think you talked about it briefly (really just jumped through parts) but this project does not work with Python3 unfortunately. There is an open issue about it in the fork though.

EDIT: Exactly a year today, actually :)

mickeelm avatar Feb 07 '19 21:02 mickeelm

@mickeelm Thanks for the heads up! I was not aware of the active fork

arnm avatar Feb 07 '19 22:02 arnm

@arnm Nice video! Thanks for the kind words too. :-)

@mickeelm @derek-adair If you want to submit a PR to the nflgame README, I'd be happy to add a link with the "unmaintained" message. Keeping a fork active for a year is good enough for me. :-)

BurntSushi avatar Feb 07 '19 22:02 BurntSushi

@BurntSushi Actually, it was this project's "unmaintainment" that had an anniversary, the fork has been around since some time around the season opener, IIRC. But I believe it is the "unofficial official fork" of nflgame, haven't seen any other at least, so I hope that's good enough :) PS. If you're still curious about NFL's data sources for other projects or whatnot, this issue might be of interest.

@derek-adair I think it's great if you are the one submitting such a PR (if you still intend to maintain the fork, I know you've been busy) :)

mickeelm avatar Feb 08 '19 09:02 mickeelm

@BurntSushi - i'm definitely committed at this point. Very happy to have earned your blessing! I will get a PR over to you today.

Just an FYI - I have scheduled plans to bring the rest of @BurntSushi 's hard work under one (maintained) roof. I still don't have any set plans, but I am considering combining some or all of these tools into one configurable namespace. At a minimum it would serve to unite the github issues, there seem to be a lot of cross-posting.

This will take place some time around end of Q1. Stay tuned!!

derek-adair avatar Feb 08 '19 13:02 derek-adair

OMFG @arnm!!!!!!! i just watched that youtube video. Awesome project.

derek-adair avatar Feb 19 '19 15:02 derek-adair

Really funny video. Hoping to help derek et al once I become a bit more familiar with the code-base and python.

cmjarrett avatar Apr 24 '19 02:04 cmjarrett