nflgame
nflgame copied to clipboard
BurntSushi
What is your plan for Season 2018 ?
This project is officially unmaintain. What are you planning for this coming season ? Are you going to self maintain individually this repo at home or are you migrating to something else (if so, what is it).
This python package had been one of the best tool for my fantasy football season so I am curious to learn about other people plan.
My partner and I converted everything (individual programs, not the DB) to PHP for our FFL … but I am so disgusted with the NFL I am shutting down my FFL (raysffl.com).
From: Irish1986 [mailto:[email protected]] Sent: Monday, July 23, 2018 10:38 AM To: BurntSushi/nflgame Cc: Subscribed Subject: [BurntSushi/nflgame] What is your plan for Season 2018 ? (#363)
This project is officially unmaintain. What are you planning for this coming season ? Are you going to self maintain individually this repo at home or are you migrating to something else (if so, what is it).
This python package had been one of the best tool for my fantasy football season so I am curious to learn about other people plan.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BurntSushi/nflgame/issues/363 , or mute the thread https://github.com/notifications/unsubscribe-auth/ACPntyn_lK8WMFDGqrjzwNMmA8NFObcYks5uJgoLgaJpZM4VbZ6z . https://github.com/notifications/beacon/ACPnt1zs6Y9E1anCfWfr_Jthdk0FPvUOks5uJgoLgaJpZM4VbZ6z.gif
Do you have the PHP code?
On Mon, Jul 23, 2018 at 1:47 PM, rjhaz [email protected] wrote:
My partner and I converted everything (individual programs, not the DB) to PHP for our FFL … but I am so disgusted with the NFL I am shutting down my FFL (raysffl.com).
From: Irish1986 [mailto:[email protected]] Sent: Monday, July 23, 2018 10:38 AM To: BurntSushi/nflgame Cc: Subscribed Subject: [BurntSushi/nflgame] What is your plan for Season 2018 ? (#363)
This project is officially unmaintain. What are you planning for this coming season ? Are you going to self maintain individually this repo at home or are you migrating to something else (if so, what is it).
This python package had been one of the best tool for my fantasy football season so I am curious to learn about other people plan.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/ BurntSushi/nflgame/issues/363> , or mute the thread <https://github.com/ notifications/unsubscribe-auth/ACPntyn_lK8WMFDGqrjzwNMmA8NFObcYks5uJg oLgaJpZM4VbZ6z> . <https://github.com/notifications/beacon/ ACPnt1zs6Y9E1anCfWfr_Jthdk0FPvUOks5uJgoLgaJpZM4VbZ6z.gif>
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BurntSushi/nflgame/issues/363#issuecomment-407143217, or mute the thread https://github.com/notifications/unsubscribe-auth/ACCilwLVk2HfTXeq1Zlt_J3K1KJMYQMcks5uJgxFgaJpZM4VbZ6z .
I do. It is a little customized for my site but easily modified… it runs on a server with LAMP. The stats collector and a couple others (like the player updates) all run from cron jobs… I collect stats every 10 minutes during every game and the web site has all the incremental stats updated each 10 minutes. But I do not have the code packaged up for distribution.
From: Donnie Laur [mailto:[email protected]] Sent: Monday, July 23, 2018 10:52 AM To: BurntSushi/nflgame Cc: rjhaz; Comment Subject: Re: [BurntSushi/nflgame] What is your plan for Season 2018 ? (#363)
Do you have the PHP code?
On Mon, Jul 23, 2018 at 1:47 PM, rjhaz [email protected] wrote:
My partner and I converted everything (individual programs, not the DB) to PHP for our FFL … but I am so disgusted with the NFL I am shutting down my FFL (raysffl.com).
From: Irish1986 [mailto:[email protected]] Sent: Monday, July 23, 2018 10:38 AM To: BurntSushi/nflgame Cc: Subscribed Subject: [BurntSushi/nflgame] What is your plan for Season 2018 ? (#363)
This project is officially unmaintain. What are you planning for this coming season ? Are you going to self maintain individually this repo at home or are you migrating to something else (if so, what is it).
This python package had been one of the best tool for my fantasy football season so I am curious to learn about other people plan.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/ BurntSushi/nflgame/issues/363> , or mute the thread <https://github.com/ notifications/unsubscribe-auth/ACPntyn_lK8WMFDGqrjzwNMmA8NFObcYks5uJg oLgaJpZM4VbZ6z> . <https://github.com/notifications/beacon/ ACPnt1zs6Y9E1anCfWfr_Jthdk0FPvUOks5uJgoLgaJpZM4VbZ6z.gif>
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BurntSushi/nflgame/issues/363#issuecomment-407143217, or mute the thread https://github.com/notifications/unsubscribe-auth/ACCilwLVk2HfTXeq1Zlt_J3K1KJMYQMcks5uJgxFgaJpZM4VbZ6z .
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BurntSushi/nflgame/issues/363#issuecomment-407144695 , or mute the thread https://github.com/notifications/unsubscribe-auth/ACPnt5Lzi1vyz2UoX7X_YnmNxTvOchyxks5uJg1PgaJpZM4VbZ6z . https://github.com/notifications/beacon/ACPntxPGatePPaP_7PJqiudYDx1ykhWeks5uJg1PgaJpZM4VbZ6z.gif
I'll be running nflgame just as I have for the past 5 seasons. Yes, it is technically un-maintained, but if we're being honest - and I don't think @BurntSushi would disagree - it wasn't being actively maintained much last year and it still worked just fine for what I needed it for. So long as the underlying Game Center JSON doesn't change much, I have full confidence that this will keep right on chugging.
I will absolutely be using this project just as @ochawkeye.
I'd be glad to contribute. It seems like its pretty much usable as is anyways.
Maybe too early to tell, but this could potentially be our first opportunity to roll up our sleeves and modify nflgame for future generations.
I've been watching with a bit of surprise that http://www.nfl.com/liveupdate/scorestrip/ss.xml has failed to move off of 2017 week 17 despite the 2018 schedule being released for quite some time.
I began poking around on NFL.com a bit and discovered that there is actually an XML out there with week-by-week schedules in identical format to what we're accustomed to seeing: ie. http://www.nfl.com/ajax/scorestrip?season=2018&seasonType=REG&week=1.
No telling if the NFL will eventually resurrect the same old scorestrip on their Game Center pages, but I'd say there's at chance that they don't as at this time old games no longer have the strip toward the top of the screen that allows navigation to any other game that week.
Edit: Nice detective work Sherlock: https://github.com/BurntSushi/nflgame/blob/db6a0b32399471aea7d36af61166ffa47ff36ea0/nflgame/update_sched.py#L40
OK, this probably won't be a problem. The reason schedule.json is not updating is because update_sched.py only looks at the years 2009 through the year that live.current_year_and_week() says it currently is. Since live.current_year_and_week() thinks it is still 2017 (according to live.CUR_SCHEDULE) even if you ask it to update --year 2018 it bails out and leaves schedule.json alone.
If you absolutely have to see nflgame give you an updated schedule, change this line to range(2009, cur_year+2) and re-run ...\nflgame\update_sched.py --year 2018. You'll find all of the 2018 preseason and regular season games now appear in your schedule.json file.
Glad to see you guys putting some time and effort into keeping this going. Thanks!
is there an alternative to nflgame ? I need to run some models for my predictions.
EDIT: I heavily used nflgame libraries from 2014 to 2016. I never bothered to investigate HOW nflgame worked. It was just working fine. I didn't use it in 2017 because my mind was in a family situation. Last week I was trying to pick up where I left. When I was trying to get all the results for 2017, I got an error saying TypeError: 'NoneType' object is not iterable. Then, I came to this github page and saw 'Project is unmaintained'. That is when I freaked out and asked for an alternative to nflgame. I had to make a little research and jump into the nflgame code. I followed advise from @ochawkeye and got into update_sched.py file, modified the line and re-run it. However, instead of using --year 2018 as parameter, I ran it with --rebuild as parameter. Now my old code works like a charm! :)
(Sorry for my English)
Chiming in here too - glad to see that there are initiatives to keep this going. As already pointed out, this project will probably be usable for a long time to come given that nfl.com doesn't make any major changes.
However, in order for this to keep going and develop (like @ochawkeye pointed out, to "roll up our sleeves") I guess some kind of "official fork" would be preferable. There are 118 open issues in this repo right now (hard to know which matter anymore and which does not) and helping each other out via comments in the issues here just isn't gonna cut it in the long run, the project simply needs to move on to a fresh start :)
@ochawkeye, my impression is that your heart is in this and therefore I was just wondering - how do you feel about the idea that your fork would be the one to follow from now on? E.g. the place to submit issues, PRs, discuss, develop. Just asking carefully, no pressure! :)
Also, shoutout once again to @BurntSushi for all the great work during these years, a huge thank you!
coming in to show some appreciation, support and to offer any contributions I can. I have leveraged nflgame/nfldb for my fantasy site for a few years now and would like to give back. Lets keep this thing alive.
I just tried this out today, bummer that it's not maintained, but thanks to @BurntSushi for putting this together! Not sure if I should start a new issue for this, but I have a problem where nflgame.games(2017, week=week) gives a TypeError for weeks 1-16, but it works fine for week 17. Does that have to do with this project not being maintained anymore?
@benlindsay Could be that nflgame is only updating the "current week" and your schedule is in need of an update. Try running python ...PATH\TO\nflgame\update_sched.py --year 2017
@mickeelm Not avoiding your question...just mulling over the responsibility associated with it. Truth is, I plan on having this running on my side so pushing it back to github really isn't a difficult thing to do. But I've seen the - literally - hundreds of queries that @BurntSushi has so patiently handled over the past 5 years and I'm not sure I'm capable of showing the restraint he has shown in fielding the majority of those.
@ochawkeye I understand that 100%, I really do. :slightly_smiling_face: Thank you for an excellent and honest answer. While it would be easy for me to say "hey, no pressure and we'll all help out" I think that a cornerstone of these kind of non-profit open source projects is to feel joy working with it, it shouldn't be a burden. So then my advice from a personal viewpoint would be to just continue as you planned in the beginning. Time will tell if you feel like pushing it back to Github or not, and what will happen or not happen if you do. I'd probably clone it if you did push it, though :wink:
I'm quite confident that this project will live on in one way or another. I also have my own project (small fantasy league) and I myself would say no right now to maintain an "official fork" for the exact reasons that you mention (also, I've only used nflgame as inspiration/taken small parts so far so I'm not super up-to-speed with the code). My plan (not promising anything though) is to build a REST-API for the database (also curious about making a NoSQL-version), since we are developing a new web site for our league. Will share it if I do.
So, let's just wait and see what happens here. Things tend to sort themselves out in the end!
@ochawkeye @mickeelm I'll be glad to fork and patiently field any requests directed at the project. I am familiar with handling merge requests, building and releasing projects so I actually would welcome the opportunity to handle that for a project such as this.
I'm not a very strong programmer but I can manage quite well so maybe this will work out. Anyone interested in participating please dont hesistate to do so ;)
Here's what I did.
In the file live.py, temporarily add this URL on line 68 after the old one.
_CUR_SCHEDULE = "http://www.nfl.com/liveupdate/scorestrip/ss.xml" _CUR_SCHEDULE = "http://www.nfl.com/ajax/scorestrip?season=2018&seasonType=REG&week=1"
@nickfrerichs if you don't want to bother updating that every week (and avoid external calls to nfl.com), check out the fork mentioned above (https://github.com/derek-adair/nflgame/). Apart from that issue it has other fixes and is actively maintained. If you just want the scheduling issue solved but not anything else, grab live.py from the fork.
@mickeelm I intent to make a large PR later this weekend to @derek-adair repo with my Py3 code and hopefully the community can get behind this repo for the continuation of this project. Hopefully this will allow the project to reborn and continue as @BurntSushi create a beautiful tool that a lot of football fan enjoy !
A lot of great information in this post...thanks. I have been looking at the data returned from the liveupdate/game-center and am curious if anyone can point me to any documentation on the JSON elements. For instance "StatID"=79 is for a tackle. There are a lot of other codes in that JSON that would be great to see documentation on instead of having to figure them out manually. Thanks
You can see the relevant map here
@tdoctor You are more than welcome to file issues like this in my forked repo. or even better if you have any insight into how the wiki can be updated i'll gladly get it in there.