nfldb icon indicating copy to clipboard operation
nfldb copied to clipboard

2017 Week 3 London Game (BAL/JAC)

Open akm0404 opened this issue 7 years ago • 5 comments

nfldb-update is not picking up this game. I see that there were issues with previous years' London games, and the start time does indeed show 9:30PM. Is there any quick fix that can be done to get this game importing? Thanks!

akm0404 avatar Sep 24 '17 14:09 akm0404

So after looking a bit more (I'm pretty novice at this, admittedly), the game does exist in schedule.json and appears correct there with the proper gsis_id, etc. I can query the NFL.com json feed with that gsis_id and the data is there. It is just in the nfldb-update process that this game isn't getting sucked into the DB...

akm0404 avatar Sep 24 '17 14:09 akm0404

Yep, same issue. New data not coming through.

brbeaird avatar Sep 24 '17 16:09 brbeaird

Its the same fix as past years. Try this. Add the following to the other elif statements in /nfldb/types.py

elif schedule['eid'] == '2017092400': d = datetime.datetime(2017, 9, 24, 9, 30) return pytz.timezone('US/Eastern').localize(d).astimezone(pytz.utc)

Then run /nflgame/update_sched.py --phase REG --year 2017

Then run nfldb-update

ThomasMorgani avatar Sep 24 '17 21:09 ThomasMorgani

19eddiedean19,

Thank you very much for that information - very very helpful. I'll add my own notes here in the event that it helps someone else going through this for the first time.

Edited /nfldb/types.py and added the elif clause for the 2017092400 eid in question.

I then ran: python2 update_sched.py --phase REG --year 2017

Output: Last updated: 2017-09-24 21:55:02.819433

I then ran nflgame-update:

nfldb-update

STARTING NFLDB UPDATE AT 2017-09-24 17:59:13.659443 Connecting to nfldb... done. Setting timezone to UTC... done. Locking write access to tables... done. Updating season phase, year and week... done. Bulk inserting data for 3 games... Sending batch of data to database. done. Updating 3 games in progress... Regular 2017 week 3 on 09/24 at 08:05PM, SEA (7) at TEN (9) Regular 2017 week 3 on 09/24 at 08:25PM, CIN (21) at GB (7) Regular 2017 week 3 on 09/24 at 08:25PM, KC (17) at LAC (10) done. Updating schedule JSON database... Last updated: 2017-09-24 21:59:07.905210 done. Updating schedule for (Postseason, 2016, 5) done. Closing database connection... done. FINISHED NFLDB UPDATE AT 2017-09-24 17:59:17.530436

That did not appear to produce any change. I then ran nfldb-update --update-schedules which ran for a couple minutes. At that point, the next nfldb-update did end up pulling in the stats from the London game.

Thanks again for getting me on the right track!

akm0404 avatar Sep 24 '17 22:09 akm0404

Will we have to do this for every London game?

etsweeney avatar Sep 26 '17 16:09 etsweeney