thunder-distribution
thunder-distribution copied to clipboard
Issue #3040605: Order of optional thunder modules install is wrong
Make sure these boxes are checked before submitting your pull request - thank you!
- [x] All coding styles are fulfilled. (How to check for cs issues?)
- [x] All tests are running locally. (How to run the test?)
- [x] Necessary update hooks are provided.
- [x] User roles have correct access for new introduced permission.
- [x] Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
- [x] Code is covered with well-balanced amount of inline comments.
If you are really awesome, then your feature is covered by additional tests. Well done!
I tried to remove the thunder_install module again in order to use
require_once $install_state['profiles']['thunder']->getPath() . '/src/Installer/Form/ModuleConfigureForm.php';
It loads the form, but the form has still service dependencies that could not be loaded. So I am wondering if loading files manually is really the best solution here. Do you have another idea, @alexpott ?
Closing in favor of https://github.com/BurdaMagazinOrg/thunder-distribution/pull/672