[Plugin]Encounter Breakdown - damage by phase

[Esstiven]

It would seem that right now theres no triggers or there is no separatiion between phases of any of the encounters in this 3.3.5 patch.

[Zidras]

Idk if this is on-hold when dbm_encounter events were removed from the code. @ajseward might explain better as I'm also interested in understanding how it currently works

[andrew6180]

https://github.com/Bunny67/Details-WotLK/blob/master/Details/functions/link.lua#L2625-L2665

so this is how it is in retail details https://github.com/Tercioo/Details-Damage-Meter/blob/master/functions/link.lua#L2618-L2658

The problem is, DBM didn't start firing "DBM_Announce" until a later expansion, so the common DBM for 3.3.5 doesn't have a standardized way of tracking which phase a fight is in.

https://github.com/ajseward/DBM-Frostmourne here's all the edits that would need to be done to any version of DBM to have it work for details, Essentially adding in DBM_Announce events to timer events, adding vb to the mod table for NewMod and adding self.vb.phase = x to each phase in every boss script that needs phasing.

The alternative is adding some way for details to track phases on its own which would be a pretty big undertaking that not even the creator of details wanted to do.

I should also mention not every single change on that github above is related to phases, but it should be easy to tell which are and which aren't.

I think bigwigs did have standardized phase tracking and would technically work with some minor changes, but bigwigs is pretty terrible in 3.3.5 and almost no one uses it.