ICBM-Classic icon indicating copy to clipboard operation
ICBM-Classic copied to clipboard

[1.12] Task: Fix radar

Open DarkGuardsman opened this issue 3 years ago • 3 comments

Closed a lot of issues and making this issue as a placeholder;

  • Fix threading issues
  • Fix redstone isues
  • Fix detection being inverted
  • Add automated testing

DarkGuardsman avatar Apr 03 '22 06:04 DarkGuardsman

Tested radar in yesterday's stream... seems to be working in 4.2.X+ version. Not sure if @GHXX or @bl4ckscor3 fixed issues with it in the previous version. Will do more testing but at minimal basic functionality works.

Still need to check threading issues and add automated testing to validate it works.

DarkGuardsman avatar May 19 '22 19:05 DarkGuardsman

Might have been fixed by this? https://github.com/BuiltBrokenModding/ICBM-Classic/pull/370

bl4ckscor3 avatar May 19 '22 19:05 bl4ckscor3

Maybe, honestly have no idea without diving the commit history. Since gitkraken is broken on linux I'm loathing to do any advanced git stuff.

DarkGuardsman avatar May 20 '22 00:05 DarkGuardsman

Fixed in 4.3.0 release

DarkGuardsman avatar Mar 20 '23 13:03 DarkGuardsman