ICBM-Classic icon indicating copy to clipboard operation
ICBM-Classic copied to clipboard

[1.12] laser designator issues

Open GHXX opened this issue 5 years ago • 3 comments

  • concurrent modification exception when triggering multiple launchers which are not chunkloaded. When moving into the launcher-chunks then the exception is thrown:
java.util.ConcurrentModificationException
	at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:909)
	at java.util.ArrayList$Itr.next(ArrayList.java:859)
	at icbm.classic.lib.radar.RadarMap.collectEntitiesInChunk(RadarMap.java:228)
	at icbm.classic.content.entity.missile.MissileEventHandler.chunkUnload(MissileEventHandler.java:43)
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_11_MissileEventHandler_chunkUnload_Unload.invoke(.dynamic)
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182)
	at net.minecraft.world.chunk.Chunk.onUnload(Chunk.java:940)
	at net.minecraft.world.gen.ChunkProviderServer.tick(ChunkProviderServer.java:287)
	at net.minecraft.world.WorldServer.tick(WorldServer.java:216)
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:831)
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:743)
	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:192)
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:592)
	at java.lang.Thread.run(Thread.java:748)

  • The laser designator triggers all available missile launchpads on the current frequency. Make it so that only one fires.

GHXX avatar Aug 27 '19 02:08 GHXX

We need to move a lot of the network code over to using scheduled events

DarkGuardsman avatar Aug 27 '19 11:08 DarkGuardsman

Stale issue message

github-actions[bot] avatar Dec 28 '19 00:12 github-actions[bot]

#311 #299 #268 #259 #242 Looks like the laser designator got tons of issues, might be best to rewrite it completely.

GHXX avatar Jun 30 '20 12:06 GHXX

Rather sure this is fixed in 5.3.x+

DarkGuardsman avatar May 21 '23 22:05 DarkGuardsman