Bricklink login fails when password contains url reserved characters

Open esampsonite opened this issue 10 years ago • 2 comments

Jul 23 '15 12:07 esampsonite

Created pull request to address this issue: https://github.com/BuildingOutLoud/Brickficiency/pull/2

Jul 23 '15 13:07 esampsonite

Hey there esampsonite, I'm pretty new to GitHub and am still trying to find my way around.

I don't quite understand how pull requests work yet and am not quite sure how they should be used. I just committed code to the "develop" branch before rather than creating a 'pull request' and am wondering if I did the wrong thing. Anyway, I had a brief look at the 'diff' of your request and it looks good to me but am unsure of what I should do with it. How are these pulls meant to be used?

Feel free to contact me directly on [email protected] if you wish.

Jul 24 '15 02:07 S-Bartfast