mitosis icon indicating copy to clipboard operation
mitosis copied to clipboard

feat: add yorkie & lint-staged

Open PengBoUESTC opened this issue 3 years ago • 5 comments

Description

Add a short description of:

  • what changes you made,
  • why you made them, and
  • any other context that you think might be helpful for someone to better understand what is contained in this pull request.

This sort of information is useful for people reviewing the code, as well as anyone from the future trying to understand why changes were made or why a bug started happening.

PengBoUESTC avatar Sep 09 '22 06:09 PengBoUESTC

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
mitosis-fiddle ✅ Ready (Inspect) Visit Preview Sep 13, 2022 at 7:33AM (UTC)

vercel[bot] avatar Sep 09 '22 06:09 vercel[bot]

@PengBoUESTC I tried this PR locally, and it didn't work. When I use git commit -m "test message" with some changes, nothing happens.

samijaber avatar Sep 09 '22 21:09 samijaber

@PengBoUESTC I tried this PR locally, and it didn't work. When I use git commit -m "test message" with some changes, nothing happens.

did you install yorkie & lint-staged dependencies? if u did, could U check the dir of .git/hooks , yorkie shuold have created some hook files in this dir ...

by the way what's your computer system,

PengBoUESTC avatar Sep 09 '22 23:09 PengBoUESTC

@PengBoUESTC I tried this PR locally, and it didn't work. When I use git commit -m "test message" with some changes, nothing happens.

did you install yorkie & lint-staged dependencies? if u did, could U check the dir of .git/hooks , yorkie shuold have created some hook files in this dir ...

by the way what's your computer system,

It does not add hooks in .git/hooks. I see that husky no longer autoinstalls https://blog.typicode.com/husky-git-hooks-autoinstall/

my computer system is M1 Mac, macOS v12

samijaber avatar Sep 12 '22 16:09 samijaber

@PengBoUESTC I tried this PR locally, and it didn't work. When I use git commit -m "test message" with some changes, nothing happens.

did you install yorkie & lint-staged dependencies? if u did, could U check the dir of .git/hooks , yorkie shuold have created some hook files in this dir ... by the way what's your computer system,

It does not add hooks in .git/hooks. I see that husky no longer autoinstalls https://blog.typicode.com/husky-git-hooks-autoinstall/

my computer system is M1 Mac, macOS v12

there is a npm hook install in yorkie; It‘s seems like that the install hook of package.json doesn't work . I know this problem in a pnpm project. may be I should solve this problem first ...

PengBoUESTC avatar Sep 13 '22 01:09 PengBoUESTC