mitosis icon indicating copy to clipboard operation
mitosis copied to clipboard

Add support for basic components in React native

Open Othman2001 opened this issue 1 year ago • 3 comments

Description

Please provide the following information:

  • What changes have you made: Support button, touchable opacity, Image and Linking

  • Why you made them, and: I think this change is very important to react native generator as it is currently is not supporting all core components.

  • Any other useful context: I think using a Button is much more convenient than pressable, that's why I migrated pressable usage to the button. the fiddle is not working properly with the Image component for some reason, but I managed to run the source code locally and tested all of my changes. Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

  • [x] Format the codebase

  • [x] Update all snapshots

Othman2001 avatar Jun 08 '24 11:06 Othman2001

🦋 Changeset detected

Latest commit: a21a753b3bf926a999aa56cb647ecd2f2d1774aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/mitosis Patch
@builder.io/mitosis-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 08 '24 11:06 changeset-bot[bot]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8531560 Triggered Generic High Entropy Secret 53feb5dcea405632e21731d15b6a6460752f4c34 nx.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Jun 08 '24 11:06 gitguardian[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a21a753b3bf926a999aa56cb647ecd2f2d1774aa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Jun 08 '24 11:06 nx-cloud[bot]

Uncovered a few other issues with how the components are being generated.

@samijaber This PR is ready for you review now, I have resolved your comments, can you please check it whenever you are free Thank you

Othman2001 avatar Jul 06 '24 12:07 Othman2001

@samijaber I have resolved the comments now, and separated the logic on two loops like we agreed, sorry if i were late.

Othman2001 avatar Jul 28 '24 08:07 Othman2001

@Othman2001 you need to re-run the snapshots one last time for it to fix a merge conflict, and you're good to go!

samijaber avatar Jul 30 '24 19:07 samijaber

@Othman2001 you need to re-run the snapshots one last time for it to fix a merge conflict, and you're good to go!

@samijaber Done I have updated the snapshots, This PR is ready to go 🥳

Othman2001 avatar Jul 31 '24 18:07 Othman2001