mitosis icon indicating copy to clipboard operation
mitosis copied to clipboard

fix: remove 2 deprecated dependencies in core package

Open rqzheng2015 opened this issue 1 year ago • 7 comments

Description

Remove 2 deprecated dependencies: vue and @babel/plugin-proposal-class-properties

Why?

  • Vue has already has its v2 version deprecated.
  • @babel/plugin-proposal-class-properties is deprecated, which can be seen in here.

Solution

Vue

There are just 1 place in core's code to import vue for its ts definition. So we could copy them and remove the import of vue2

@babel/plugin-proposal-class-properties

As there were 0 places to import @babel/plugin-proposal-class-properties, we could just remove the import of it.

rqzheng2015 avatar Mar 18 '24 13:03 rqzheng2015

🦋 Changeset detected

Latest commit: 22a0ac4ef1d069a00e3aadcff7af54375c72244c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/mitosis Patch
@builder.io/mitosis-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Mar 18 '24 13:03 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mitosis-fiddle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 1:40pm

vercel[bot] avatar Mar 18 '24 13:03 vercel[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 22a0ac4ef1d069a00e3aadcff7af54375c72244c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Mar 18 '24 13:03 nx-cloud[bot]

Hi @samijaber, please check this PR if you are free, thanks.

rqzheng2015 avatar May 04 '24 10:05 rqzheng2015

Hi @samijaber, please check this PR when you are free. It reduces some unnecessary dependencies in core package, which might speed up the installation process.

rqzheng2015 avatar Jun 25 '24 09:06 rqzheng2015

Thanks for this contribution! 🙏🏽

samijaber avatar Jun 27 '24 20:06 samijaber

Hi @samijaber , sorry to bother again. But the github checks seems to be waiting for Cloudflare pages to be deployed, how could I run this Cloudlflare check manually? It is now stucking. Please check this when you are free, thanks.

rqzheng2015 avatar Jun 30 '24 15:06 rqzheng2015

@rqzheng2015 That check shouldn't be there, it's a mistake. Your PR is good to go and merged!

samijaber avatar Jul 02 '24 15:07 samijaber