mitosis icon indicating copy to clipboard operation
mitosis copied to clipboard

fix: Sveltosis behaviour on inputs

Open simongeau opened this issue 2 years ago • 3 comments

The goal is to make sure inputs and textarea are binded onInput instead of onChange (which is triggered on blur) so that it is more inline with the Svelte rendering

simongeau avatar Mar 04 '23 01:03 simongeau

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mitosis-fiddle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2023 4:49pm

vercel[bot] avatar Mar 04 '23 01:03 vercel[bot]

@simongeau Thanks for adding this fix!

If you can follow the steps outlined here: https://github.com/BuilderIO/mitosis/blob/main/developer/README.md#developing-for-core--testing

Essentially: add tests that highlight this change, and format your PR to pass the CI checks. Then we can get this merged in 🙏🏽

samijaber avatar Jun 16 '23 16:06 samijaber

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8f72373a5a54c65651f69dca89262a633b76c0e7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Jun 16 '23 17:06 nx-cloud[bot]