builder icon indicating copy to clipboard operation
builder copied to clipboard

[react-native] Support for react-dom@19

Open kerwanp opened this issue 5 months ago • 3 comments

Description

In react-dom@19 the function findDOMNode has been removed. Instead the ref actually contains the Element. To support both 18 and 19 version we check wether findDOMNode is defined.

image

kerwanp avatar Jun 30 '25 10:06 kerwanp

🦋 Changeset detected

Latest commit: af4e2a759a58744866a07d0e7122572ee32a66c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@builder.io/sdk-react-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 30 '25 10:06 changeset-bot[bot]

View your CI Pipeline Execution ↗ for commit af4e2a759a58744866a07d0e7122572ee32a66c4.

Command Status Duration Result
nx test @snippet/react-sdk-next-14-app ✅ Succeeded 1m 15s View ↗
nx test @snippet/angular-17 ✅ Succeeded 2m 50s View ↗
nx test @e2e/gen1-next15-app ✅ Succeeded 6m 5s View ↗
nx test @e2e/gen1-react ✅ Succeeded 5m 26s View ↗
nx test @e2e/gen1-remix ✅ Succeeded 5m 19s View ↗
nx test @snippet/angular-17-ssr ✅ Succeeded 1m 26s View ↗
nx test @snippet/hydrogen ✅ Succeeded 1m 7s View ↗
nx test @snippet/react-sdk-next-pages ✅ Succeeded 2m 32s View ↗
Additional runs (18) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-06-30 11:01:46 UTC

nx-cloud[bot] avatar Jun 30 '25 10:06 nx-cloud[bot]

On as side note, I gave react-compiler a try on our Expo app and it failed. It seems related to Builder as the type prop of the JSX element provided for components with children become undefined with react-compiler.

In the following example children[0].type is a JSX.Element with $$typeof: Symbol(react.memo). With react-compiler it becomes undefined.

{
    name: "MyComponent",
    component: ({ children }) => {
       console.log(children[0].type)
       return children
    },
    canHaveChildren: true,
}

I will find some time for testing and maybe opening an other PR for react-compiler support

kerwanp avatar Jun 30 '25 15:06 kerwanp