builder icon indicating copy to clipboard operation
builder copied to clipboard

Add Optional Params to Fetch

Open Torrus168 opened this issue 1 year ago • 5 comments

Description

MVP connected to the https://github.com/BuilderIO/builder/issues/3641 issue

Torrus168 avatar Oct 17 '24 10:10 Torrus168

🦋 Changeset detected

Latest commit: 3a4320747e547c6534a2ac0b7e9ac33b8e88308e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/sdk Patch
@builder.io/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 17 '24 10:10 changeset-bot[bot]

Great job! It'd allow to use tag-based caching in Next.js projects.

vonschau avatar Oct 17 '24 10:10 vonschau

@sidmohanty11 this PR is not tested and might require a few looks, although seems mainly correct. As mentioned by @vonschau and me in the issue, it'd really benefit the Next.JS setup for your tool 🙏

Torrus168 avatar Oct 17 '24 13:10 Torrus168

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11707119 Triggered Generic High Entropy Secret 2ad593e4ba541fccdcd86299a22c41f58b22a4b2 packages/sdks/snippets/angular/src/app/nav-bar/nav-bar.component.ts View secret
11707119 Triggered Generic High Entropy Secret 2ad593e4ba541fccdcd86299a22c41f58b22a4b2 packages/sdks/snippets/angular-ssr/src/app/product-details/product-details.resolver.ts View secret
11707119 Triggered Generic High Entropy Secret 2ad593e4ba541fccdcd86299a22c41f58b22a4b2 packages/sdks/snippets/angular-ssr/src/app/nav-bar/nav-bar.resolver.ts View secret
14200383 Triggered Generic High Entropy Secret 04ea2234acb6e4ac1d237572833c27fb13d646ef packages/core/src/builder.class.test.ts View secret
14200384 Triggered Generic High Entropy Secret 04ea2234acb6e4ac1d237572833c27fb13d646ef packages/core/src/builder.class.test.ts View secret
14200385 Triggered Generic High Entropy Secret 04ea2234acb6e4ac1d237572833c27fb13d646ef packages/core/src/builder.class.test.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Oct 18 '24 13:10 gitguardian[bot]

@samijaber @sidmohanty11 any news on this topic? 🙏

Torrus168 avatar Oct 21 '24 08:10 Torrus168

@sidmohanty11 screenshot showing how the options do work: CleanShot 2024-10-21 at 12 32 13@2x

samijaber avatar Oct 21 '24 15:10 samijaber

Thanks a lot for the contribution @Torrus168 🙏🏽

samijaber avatar Oct 23 '24 12:10 samijaber

Thanks for the support folks! @samijaber @sidmohanty11 🙏

Torrus168 avatar Oct 23 '24 12:10 Torrus168