Add Optional Params to Fetch
Description
MVP connected to the https://github.com/BuilderIO/builder/issues/3641 issue
🦋 Changeset detected
Latest commit: 3a4320747e547c6534a2ac0b7e9ac33b8e88308e
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
| Name | Type |
|---|---|
| @builder.io/sdk | Patch |
| @builder.io/react | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Great job! It'd allow to use tag-based caching in Next.js projects.
☁️ Nx Cloud Report
CI is running/has finished running commands for commit 3a4320747e547c6534a2ac0b7e9ac33b8e88308e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 39 targets
nx test @e2e/qwik-citynx test @e2e/nextjs-sdk-next-appnx test @e2e/vuenx test @e2e/nuxtnx test @e2e/hydrogennx test @e2e/sveltenx test @e2e/sveltekitnx test @e2e/react-nativenx test @e2e/angular-ssrnx test @e2e/react-sdk-next-appnx test @e2e/angularnx test @e2e/react-sdk-next-pagesnx test @e2e/remixnx test @e2e/solid-startnx test @e2e/solidnx test @e2e/gen1-reactnx test @e2e/reactnx test @snippet/react-nativenx test @e2e/gen1-remixnx test @snippet/angular-ssrnx test @e2e/gen1-nextnx test @snippet/qwik-citynx test @snippet/reactnx test @snippet/nextjs-sdk-next-appnx test @snippet/sveltekitnx test @snippet/angularnx test @snippet/react-sdk-next-pagesnx test @snippet/sveltenx test @snippet/nuxtnx test @snippet/react-sdk-next-appnx test @snippet/vuenx test @snippet/hydrogennx test @snippet/solidnx test @snippet/gen1-reactnx test @snippet/gen1-remixnx test @snippet/gen1-nextnx test @builder.io/sdksnx typecheck @builder.io/sdksnx build @builder.io/sdk
Sent with 💌 from NxCloud.
@sidmohanty11 this PR is not tested and might require a few looks, although seems mainly correct. As mentioned by @vonschau and me in the issue, it'd really benefit the Next.JS setup for your tool 🙏
⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 11707119 | Triggered | Generic High Entropy Secret | 2ad593e4ba541fccdcd86299a22c41f58b22a4b2 | packages/sdks/snippets/angular/src/app/nav-bar/nav-bar.component.ts | View secret |
| 11707119 | Triggered | Generic High Entropy Secret | 2ad593e4ba541fccdcd86299a22c41f58b22a4b2 | packages/sdks/snippets/angular-ssr/src/app/product-details/product-details.resolver.ts | View secret |
| 11707119 | Triggered | Generic High Entropy Secret | 2ad593e4ba541fccdcd86299a22c41f58b22a4b2 | packages/sdks/snippets/angular-ssr/src/app/nav-bar/nav-bar.resolver.ts | View secret |
| 14200383 | Triggered | Generic High Entropy Secret | 04ea2234acb6e4ac1d237572833c27fb13d646ef | packages/core/src/builder.class.test.ts | View secret |
| 14200384 | Triggered | Generic High Entropy Secret | 04ea2234acb6e4ac1d237572833c27fb13d646ef | packages/core/src/builder.class.test.ts | View secret |
| 14200385 | Triggered | Generic High Entropy Secret | 04ea2234acb6e4ac1d237572833c27fb13d646ef | packages/core/src/builder.class.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@samijaber @sidmohanty11 any news on this topic? 🙏
@sidmohanty11 screenshot showing how the options do work:
Thanks a lot for the contribution @Torrus168 🙏🏽
Thanks for the support folks! @samijaber @sidmohanty11 🙏