BuilderIO
Fix: SDKs Eval
🦋 Changeset detected
Latest commit: b45d60e59b964ec1cdcaf33504a1f0bdb71a02d8
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
| Name | Type |
|---|---|
| @builder.io/sdk-angular | Patch |
| @builder.io/sdk-react-nextjs | Patch |
| @builder.io/sdk-qwik | Patch |
| @builder.io/sdk-react | Patch |
| @builder.io/sdk-react-native | Patch |
| @builder.io/sdk-solid | Patch |
| @builder.io/sdk-svelte | Patch |
| @builder.io/sdk-vue | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
☁️ Nx Cloud Report
CI is running/has finished running commands for commit b45d60e59b964ec1cdcaf33504a1f0bdb71a02d8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 39 targets
nx test @e2e/qwik-citynx test @e2e/nextjs-sdk-next-appnx test @e2e/nuxtnx test @e2e/solidnx test @e2e/react-nativenx test @e2e/react-sdk-next-appnx test @e2e/sveltekitnx test @e2e/hydrogennx test @e2e/sveltenx test @e2e/angularnx test @e2e/solid-startnx test @e2e/react-sdk-next-pagesnx test @e2e/angular-ssrnx test @e2e/vuenx test @e2e/remixnx test @e2e/reactnx test @e2e/gen1-reactnx test @e2e/gen1-remixnx test @snippet/react-nativenx test @snippet/react-sdk-next-appnx test @snippet/angular-ssrnx test @snippet/angularnx test @e2e/gen1-nextnx test @snippet/sveltekitnx test @snippet/nextjs-sdk-next-appnx test @snippet/qwik-citynx test @snippet/sveltenx test @snippet/reactnx test @snippet/vuenx test @snippet/nuxtnx test @snippet/hydrogennx test @snippet/react-sdk-next-pagesnx test @snippet/solidnx test @snippet/gen1-reactnx test @builder.io/sdksnx typecheck @builder.io/sdksnx test @snippet/gen1-remixnx test @snippet/gen1-nextnx build @builder.io/sdk
Sent with 💌 from NxCloud.
![nx-cloud[bot] avatar](https://avatars.githubusercontent.com/in/80458?v=4 "Published by a pub.dev verified publisher"){kind=small}
⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 11707119 | Triggered | Generic High Entropy Secret | 10d70402f5501a7eef763baee710954c52f7a7c6 | packages/sdks/snippets/angular/src/app/product-details/product-details.component.ts | View secret |
| 11707119 | Triggered | Generic High Entropy Secret | 10d70402f5501a7eef763baee710954c52f7a7c6 | packages/sdks/snippets/angular-ssr/src/app/nav-bar/nav-bar.resolver.ts | View secret |
| 11707119 | Triggered | Generic High Entropy Secret | 10d70402f5501a7eef763baee710954c52f7a7c6 | packages/sdks/snippets/angular-ssr/src/app/product-editorial/product-editorial.resolver.ts | View secret |
| 11707119 | Triggered | Generic High Entropy Secret | 10d70402f5501a7eef763baee710954c52f7a7c6 | packages/sdks/snippets/angular-ssr/src/app/product-details/product-details.resolver.ts | View secret |
| 11707119 | Triggered | Generic High Entropy Secret | 10d70402f5501a7eef763baee710954c52f7a7c6 | packages/sdks/snippets/angular/src/app/nav-bar/nav-bar.component.ts | View secret |
| 14200383 | Triggered | Generic High Entropy Secret | 10d70402f5501a7eef763baee710954c52f7a7c6 | packages/core/src/builder.class.test.ts | View secret |
| 14200384 | Triggered | Generic High Entropy Secret | 10d70402f5501a7eef763baee710954c52f7a7c6 | packages/core/src/builder.class.test.ts | View secret |
| 14200385 | Triggered | Generic High Entropy Secret | 10d70402f5501a7eef763baee710954c52f7a7c6 | packages/core/src/builder.class.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
![gitguardian[bot] avatar](https://avatars.githubusercontent.com/in/46505?v=4 "Published by a pub.dev verified publisher"){kind=small}
does this also handle the fact that the bindings rarely actually look like state.foo and instead look like var _virtual_index=state.foo;return _virtual_index
looking at your PR it seems to assume the binding value is always in the unprocessed format (but could be wrong)
tl;dr in the app we compile TS to JS, and the way our rollup setup works state.whatever in JS becomes var _virtual_index=state.whatever;return _virtual_index so we'd ideally be able to match that and parse from there as well
