feat[core][Builder]: ENG-6751 change to type of onChange
Description
Make onChange to provide 2 arguments - options and previousOptions
Dependent PR on Web-app https://github.com/BuilderIO/builder-internal/pull/7089
Jira ticket https://builder-io.atlassian.net/browse/ENG-6751
🦋 Changeset detected
Latest commit: 889df478585de28af9f13c2ae7bc4015ddf4ffeb
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 10 packages
| Name | Type |
|---|---|
| @builder.io/sdk | Patch |
| @builder.io/sdk-angular | Patch |
| @builder.io/sdk-react-nextjs | Patch |
| @builder.io/sdk-qwik | Patch |
| @builder.io/sdk-react | Patch |
| @builder.io/sdk-react-native | Patch |
| @builder.io/sdk-solid | Patch |
| @builder.io/sdk-svelte | Patch |
| @builder.io/sdk-vue | Patch |
| @builder.io/react | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
☁️ Nx Cloud Report
CI is running/has finished running commands for commit 889df478585de28af9f13c2ae7bc4015ddf4ffeb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 39 targets
nx test @e2e/qwik-citynx test @e2e/nextjs-sdk-next-appnx test @e2e/nuxtnx test @e2e/hydrogennx test @e2e/react-nativenx test @e2e/sveltekitnx test @e2e/angular-ssrnx test @e2e/react-sdk-next-appnx test @e2e/sveltenx test @e2e/angularnx test @e2e/solidnx test @e2e/vuenx test @e2e/react-sdk-next-pagesnx test @e2e/solid-startnx test @e2e/remixnx test @e2e/gen1-reactnx test @e2e/reactnx test @snippet/react-nativenx test @snippet/angular-ssrnx test @e2e/gen1-remixnx test @e2e/gen1-nextnx test @snippet/angularnx test @snippet/nextjs-sdk-next-appnx test @snippet/sveltenx test @snippet/react-sdk-next-appnx test @snippet/react-sdk-next-pagesnx test @snippet/sveltekitnx test @snippet/nuxtnx test @snippet/hydrogennx test @snippet/reactnx test @snippet/solidnx test @snippet/vuenx test @snippet/qwik-citynx test @snippet/gen1-nextnx test @snippet/gen1-reactnx test @snippet/gen1-remixnx test @builder.io/sdksnx typecheck @builder.io/sdksnx build @builder.io/sdk
Sent with 💌 from NxCloud.
⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 11707119 | Triggered | Generic High Entropy Secret | 206e0f905d38d2638af17fcc4d70e96e257b4821 | packages/sdks/snippets/angular-ssr/src/app/product-editorial/product-editorial.resolver.ts | View secret |
| 11707119 | Triggered | Generic High Entropy Secret | 889df478585de28af9f13c2ae7bc4015ddf4ffeb | packages/sdks/snippets/angular-ssr/src/app/product-details/product-details.resolver.ts | View secret |
| 11707119 | Triggered | Generic High Entropy Secret | 889df478585de28af9f13c2ae7bc4015ddf4ffeb | packages/sdks/snippets/angular-ssr/src/app/nav-bar/nav-bar.resolver.ts | View secret |
| 11707119 | Triggered | Generic High Entropy Secret | 206e0f905d38d2638af17fcc4d70e96e257b4821 | packages/sdks/snippets/angular/src/app/product-details/product-details.component.ts | View secret |
| 11707119 | Triggered | Generic High Entropy Secret | 889df478585de28af9f13c2ae7bc4015ddf4ffeb | packages/sdks/snippets/angular/src/app/nav-bar/nav-bar.component.ts | View secret |
| 14200383 | Triggered | Generic High Entropy Secret | ef6a5e08a3dc0dcf158db6c3e53874b791139611 | packages/core/src/builder.class.test.ts | View secret |
| 14200384 | Triggered | Generic High Entropy Secret | ef6a5e08a3dc0dcf158db6c3e53874b791139611 | packages/core/src/builder.class.test.ts | View secret |
| 14200385 | Triggered | Generic High Entropy Secret | ef6a5e08a3dc0dcf158db6c3e53874b791139611 | packages/core/src/builder.class.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.