builder icon indicating copy to clipboard operation
builder copied to clipboard

add support for responsive styles in gen1 react sdk and memoize processBlock

Open steve8708 opened this issue 1 year ago • 3 comments

we don't use the post-processed responsiveStyles object that bindings influence, but instead the preprocessed one

gen2 supports this, but not gen1

also, i removed several repeat calls to processBlock() which is very bad for perf as that runs al l theb indings, and it was running many times per block instead of 1x like gen1 SDK

steve8708 avatar Aug 08 '24 23:08 steve8708

⚠️ No Changeset found

Latest commit: d28da60a8f8045e795dd6771b0af11bd53234e07

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 08 '24 23:08 changeset-bot[bot]

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
2708648 Triggered Generic High Entropy Secret 0123b30f118c81702986f08baab222e4d812d168 packages/sdks-tests/src/specs/text-eval.ts View secret
2708648 Triggered Generic High Entropy Secret 0123b30f118c81702986f08baab222e4d812d168 packages/sdks-tests/src/specs/text-eval.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Aug 26 '24 21:08 gitguardian[bot]

Closing this due to being superseded by #3519 and #3522

samijaber avatar Sep 27 '24 21:09 samijaber