builder icon indicating copy to clipboard operation
builder copied to clipboard

[fix][sdk][Embed] ENG-5905 Fix Embed block to support url localizations

Open murtaza-builder opened this issue 1 year ago • 4 comments

Description

When embed block's url is localized, we need to localize the content field as well which is inserted in the rendered content

murtaza-builder avatar Jun 22 '24 15:06 murtaza-builder

⚠️ No Changeset found

Latest commit: f59c39515b95e89f26f8d6fcf88850294fd79c7e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 22 '24 15:06 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-app-router-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 3:21pm
nextjs-pages-router-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 3:21pm
remix-gen2-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 3:21pm
svelte-vite-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 3:21pm

vercel[bot] avatar Jun 22 '24 15:06 vercel[bot]

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
375825 Triggered Generic High Entropy Secret f59c39515b95e89f26f8d6fcf88850294fd79c7e packages/react/src/blocks/Embed.tsx View secret
375825 Triggered Generic High Entropy Secret f59c39515b95e89f26f8d6fcf88850294fd79c7e packages/react/src/blocks/Embed.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Jun 22 '24 15:06 gitguardian[bot]

Closing this in favor of other PR that handles it in webapp itself.

murtaza-builder avatar Jul 29 '24 12:07 murtaza-builder