builder
builder copied to clipboard
[fix][sdk][Embed] ENG-5905 Fix Embed block to support url localizations
Description
When embed block's url is localized, we need to localize the content field as well which is inserted in the rendered content
⚠️ No Changeset found
Latest commit: f59c39515b95e89f26f8d6fcf88850294fd79c7e
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| nextjs-app-router-example | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 22, 2024 3:21pm |
| nextjs-pages-router-example | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 22, 2024 3:21pm |
| remix-gen2-example | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 22, 2024 3:21pm |
| svelte-vite-example | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 22, 2024 3:21pm |
⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 375825 | Triggered | Generic High Entropy Secret | f59c39515b95e89f26f8d6fcf88850294fd79c7e | packages/react/src/blocks/Embed.tsx | View secret |
| 375825 | Triggered | Generic High Entropy Secret | f59c39515b95e89f26f8d6fcf88850294fd79c7e | packages/react/src/blocks/Embed.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
☁️ Nx Cloud Report
CI is running/has finished running commands for commit f59c39515b95e89f26f8d6fcf88850294fd79c7e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
| ⤵️ And 25 more
- nx typecheck @builder.io/sdks
- nx test @snippet/nuxt
- nx test @e2e/nuxt
- nx test @e2e/solid-start
- nx test @snippet/angular
- nx test @e2e/gen1-remix
- nx test @e2e/vue
- nx test @snippet/solid
- nx test @e2e/next-pages-dir
- nx test @e2e/next-app-dir-client
- nx test @snippet/next-app-dir-client
- nx test @e2e/react-native
- nx test @snippet/next-pages-dir
- nx test @e2e/gen1-next
- nx test @snippet/next-app-dir
- nx test @e2e/qwik-city
- nx test @snippet/vue
- nx test @e2e/react
- nx test @e2e/next-app-dir
- nx test @e2e/remix
- nx test @e2e/solid
- nx test @snippet/sveltekit
- nx test @e2e/gen1-react
- nx test @e2e/angular
- nx test @e2e/angular-ssr
✅ Successfully ran 1 target
Sent with 💌 from NxCloud.
Closing this in favor of other PR that handles it in webapp itself.