builder icon indicating copy to clipboard operation
builder copied to clipboard

fix: angular ssr e2e tests

Open sidmohanty11 opened this issue 1 year ago • 3 comments

Description

Fixes Angular SSR project with actually SSRing content and flakiness of the CI

Jira https://builder-io.atlassian.net/browse/ENG-6053

Screenshot If relevant, add a screenshot or two of the changes you made.

sidmohanty11 avatar Jun 19 '24 12:06 sidmohanty11

🦋 Changeset detected

Latest commit: a15fb49b73ed7f1c67156b63a4749c6e14d3d158

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@builder.io/sdk-angular Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 19 '24 12:06 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-app-router-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 4:39am
nextjs-pages-router-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 4:39am
remix-gen2-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 4:39am
svelte-vite-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 4:39am

vercel[bot] avatar Jun 19 '24 12:06 vercel[bot]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
2708648 Triggered Generic High Entropy Secret a15fb49b73ed7f1c67156b63a4749c6e14d3d158 examples/next-js-sdk-gen-2-experimental-app-directory/src/app/[[...slug]]/page.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Jul 11 '24 12:07 gitguardian[bot]