builder
builder copied to clipboard
fix: angular ssr e2e tests
Description
Fixes Angular SSR project with actually SSRing content and flakiness of the CI
Jira https://builder-io.atlassian.net/browse/ENG-6053
Screenshot If relevant, add a screenshot or two of the changes you made.
🦋 Changeset detected
Latest commit: a15fb49b73ed7f1c67156b63a4749c6e14d3d158
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @builder.io/sdk-angular | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| nextjs-app-router-example | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 25, 2024 4:39am |
| nextjs-pages-router-example | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 25, 2024 4:39am |
| remix-gen2-example | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 25, 2024 4:39am |
| svelte-vite-example | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 25, 2024 4:39am |
☁️ Nx Cloud Report
CI is running/has finished running commands for commit a15fb49b73ed7f1c67156b63a4749c6e14d3d158. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 35 targets
nx test @e2e/angular-ssrnx test @e2e/qwik-citynx test @e2e/angularnx test @e2e/nuxtnx test @e2e/sveltekitnx test @e2e/sveltenx test @e2e/vuenx test @e2e/next-app-dirnx test @e2e/next-app-dir-clientnx test @e2e/react-nativenx test @e2e/solidnx test @e2e/remixnx test @e2e/solid-startnx test @e2e/next-pages-dirnx test @e2e/reactnx test @e2e/hydrogennx test @snippet/react-nativenx test @e2e/gen1-remixnx test @snippet/reactnx test @snippet/sveltekitnx test @e2e/gen1-reactnx test @snippet/sveltenx test @snippet/vuenx test @snippet/angular-ssrnx test @snippet/next-app-dir-clientnx test @snippet/next-pages-dirnx test @snippet/nuxtnx test @snippet/qwik-citynx test @snippet/solidnx test @snippet/angularnx test @snippet/next-app-dirnx test @e2e/gen1-nextnx test @builder.io/sdksnx typecheck @builder.io/sdksnx build @builder.io/sdk
Sent with 💌 from NxCloud.
⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.
🔎 Detected hardcoded secret in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 2708648 | Triggered | Generic High Entropy Secret | a15fb49b73ed7f1c67156b63a4749c6e14d3d158 | examples/next-js-sdk-gen-2-experimental-app-directory/src/app/[[...slug]]/page.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.