builder icon indicating copy to clipboard operation
builder copied to clipboard

ENG-2956 Honor custom breakpoints, if available, when rendering content

Open murtaza-builder opened this issue 3 years ago • 2 comments

Description

When custom break-points are available in content data, re-initialize size constants, from builder-component 's constructor with supplied values. This is so that the corresponding rendering flow can proceed w/o any further changes.

  • A content json can have custom breakpoints specified at content.data.breakpoints content.data.breakpoints = {small: , medium: }

React SDK: Honor custom breakpoints when rendering content

Note: App level changes to save breakpoint data in content is yet to be done.

murtaza-builder avatar Sep 05 '22 07:09 murtaza-builder

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
svelte-vite-example ✅ Ready (Inspect) Visit Preview Sep 23, 2022 at 0:58AM (UTC)

vercel[bot] avatar Sep 05 '22 07:09 vercel[bot]

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 4df6fb5faf33f1aa599242c342ee851c3385cefb packages/sdks/src/functions/get-content/snapshots/fn.test.ts.snap View secret
- Generic High Entropy Secret 4df6fb5faf33f1aa599242c342ee851c3385cefb packages/sdks/src/functions/get-content/snapshots/fn.test.ts.snap View secret
- Generic High Entropy Secret 4df6fb5faf33f1aa599242c342ee851c3385cefb packages/sdks/src/functions/get-content/snapshots/fn.test.ts.snap View secret
- Generic High Entropy Secret 4df6fb5faf33f1aa599242c342ee851c3385cefb packages/sdks/src/functions/get-content/snapshots/fn.test.ts.snap View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Sep 05 '22 07:09 gitguardian[bot]